WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
39495
All callable objects should have a global object reference
https://bugs.webkit.org/show_bug.cgi?id=39495
Summary
All callable objects should have a global object reference
Oliver Hunt
Reported
2010-05-21 09:54:07 PDT
All callable objects should have a global object reference
Attachments
Patch
(187.53 KB, patch)
2010-05-21 10:31 PDT
,
Oliver Hunt
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Oliver Hunt
Comment 1
2010-05-21 10:31:53 PDT
Created
attachment 56726
[details]
Patch
Geoffrey Garen
Comment 2
2010-05-21 10:54:49 PDT
Comment on
attachment 56726
[details]
Patch Please mention your performance testing results in the ChangeLog. + All objects that may ever return a value other CallTypeNone + or ConstructTypeNone now get a global object in their constructor Typo: Should be "other than". Please fix EWS failures. Since we can't use C++ subclassing, I wonder if there's some other centralized choke-point we can use for ensuring our anonymous slot contract. The ASSERT is good, but it would be better to catch an error even earlier, like at object construction time. For example, maybe we need a Structure::createCallable. r=me
Oliver Hunt
Comment 3
2010-05-21 11:20:44 PDT
Committed
r59941
Eric Seidel (no email)
Comment 4
2010-05-21 11:35:13 PDT
Broke the windows build. My appologies that the win builder is not caught up yet.
WebKit Review Bot
Comment 5
2010-05-21 11:40:47 PDT
http://trac.webkit.org/changeset/59941
might have broken Qt Linux ARMv5 Release
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug