Bug 39495 - All callable objects should have a global object reference
Summary: All callable objects should have a global object reference
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-05-21 09:54 PDT by Oliver Hunt
Modified: 2010-05-21 11:40 PDT (History)
3 users (show)

See Also:

Patch (187.53 KB, patch)
2010-05-21 10:31 PDT, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2010-05-21 09:54:07 PDT
All callable objects should have a global object reference
Comment 1 Oliver Hunt 2010-05-21 10:31:53 PDT
Created attachment 56726 [details]
Comment 2 Geoffrey Garen 2010-05-21 10:54:49 PDT
Comment on attachment 56726 [details]

Please mention your performance testing results in the ChangeLog.

+        All objects that may ever return a value other CallTypeNone
+        or ConstructTypeNone now get a global object in their constructor

Typo: Should be "other than".

Please fix EWS failures.

Since we can't use C++ subclassing, I wonder if there's some other centralized choke-point we can use for ensuring our anonymous slot contract. The ASSERT is good, but it would be better to catch an error even earlier, like at object construction time. For example, maybe we need a Structure::createCallable.

Comment 3 Oliver Hunt 2010-05-21 11:20:44 PDT
Committed r59941
Comment 4 Eric Seidel (no email) 2010-05-21 11:35:13 PDT
Broke the windows build.  My appologies that the win builder is not caught up yet.
Comment 5 WebKit Review Bot 2010-05-21 11:40:47 PDT
http://trac.webkit.org/changeset/59941 might have broken Qt Linux ARMv5 Release