Bug 39452 - caller of scheduleLocationChange in V8 binding and generic binding used the wrong signature
Summary: caller of scheduleLocationChange in V8 binding and generic binding used the w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-20 15:32 PDT by Grace Kloba
Modified: 2010-05-23 02:52 PDT (History)
2 users (show)

See Also:

Attachments
Bug fix (2.13 KB, patch)
2010-05-20 22:10 PDT, Grace Kloba 		no flags Details | Formatted Diff | Diff
Fix the format issue in the previous patch (2.33 KB, patch)
2010-05-21 08:50 PDT, Grace Kloba 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grace Kloba 2010-05-20 15:32:44 PDT 
Both V8 binding and generic binding assumes scheduleLocationChange() has four inputs. Here is the code snippet

            frame->redirectScheduler()->scheduleLocationChange(completedUrl, referrer, false, userGesture);

But it actually has five. See below. 

    void scheduleLocationChange(const String& url, const String& referrer, bool lockHistory = true, bool lockBackForwardList = true, bool userGesture = false);

This caused userGesture maps to lockBackForwardList and userGesture is always false.

Patch is coming.
Comment 1 Grace Kloba 2010-05-20 22:10:42 PDT 
Created attachment 56669 [details]
Bug fix
Comment 2 Grace Kloba 2010-05-21 08:50:30 PDT 
Created attachment 56713 [details]
Fix the format issue in the previous patch
Comment 3 Nate Chapin 2010-05-21 09:13:02 PDT 
Comment on attachment 56713 [details]
Fix the format issue in the previous patch

Ok.
Comment 4 WebKit Commit Bot 2010-05-23 02:52:42 PDT 
Comment on attachment 56713 [details]
Fix the format issue in the previous patch

Clearing flags on attachment: 56713

Committed r60036: <http://trac.webkit.org/changeset/60036>
Comment 5 WebKit Commit Bot 2010-05-23 02:52:47 PDT 
All reviewed patches have been landed.  Closing bug.