RESOLVED FIXED 39449
[Qt] Fix coding style in GraphicsLayerQt 
https://bugs.webkit.org/show_bug.cgi?id=39449
Summary [Qt] Fix coding style in GraphicsLayerQt
Kenneth Rohde Christiansen
Reported 2010-05-20 15:11:12 PDT
Created attachment 56638 [details] Patch Do some clean up in GraphicsLayerQt
Attachments
Patch (43.72 KB, patch)
2010-05-20 15:11 PDT, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Patch 2 (43.85 KB, patch)
2010-05-20 15:50 PDT, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Patch 3 (43.93 KB, patch)
2010-05-21 05:59 PDT, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Patch 4 (57.42 KB, patch)
2010-05-21 09:22 PDT, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Rebased patch (57.49 KB, patch)
2010-05-21 10:07 PDT, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Patch 5, compiles for me and Luiz :-) (57.41 KB, patch)
2010-05-21 11:01 PDT, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Here we go again (57.18 KB, patch)
2010-05-21 11:19 PDT, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Early Warning System Bot
Comment 1 2010-05-20 15:29:18 PDT
Attachment 56638 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/2300379
Kenneth Rohde Christiansen
Comment 2 2010-05-20 15:50:19 PDT
Created attachment 56642 [details] Patch 2
Early Warning System Bot
Comment 3 2010-05-20 15:59:23 PDT
Attachment 56642 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/2316373
Kenneth Rohde Christiansen
Comment 4 2010-05-21 05:55:13 PDT
For some reason it is not rebuilding the .o on my system. The patch should be right next time.
Kenneth Rohde Christiansen
Comment 5 2010-05-21 05:59:29 PDT
Created attachment 56701 [details] Patch 3
Early Warning System Bot
Comment 6 2010-05-21 06:04:49 PDT
Attachment 56701 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/2251408
Kenneth Rohde Christiansen
Comment 7 2010-05-21 09:22:08 PDT
Created attachment 56714 [details] Patch 4
Kenneth Rohde Christiansen
Comment 8 2010-05-21 10:07:33 PDT
Created attachment 56721 [details] Rebased patch
Early Warning System Bot
Comment 9 2010-05-21 10:14:24 PDT
Attachment 56721 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/2312418
Kenneth Rohde Christiansen
Comment 10 2010-05-21 10:19:07 PDT
Ossy, do you know if you build with other flags. The errors are right, but I don't get any locally and I manually delete the .o before compiling again.
Kenneth Rohde Christiansen
Comment 11 2010-05-21 11:01:50 PDT
Created attachment 56729 [details] Patch 5, compiles for me and Luiz :-)
Early Warning System Bot
Comment 12 2010-05-21 11:10:59 PDT
Attachment 56729 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/2262432
Kenneth Rohde Christiansen
Comment 13 2010-05-21 11:19:11 PDT
Created attachment 56730 [details] Here we go again
Eric Seidel (no email)
Comment 14 2010-05-21 12:02:22 PDT
Comment on attachment 56730 [details] Here we go again rs=me. Yay for cleanup!
WebKit Commit Bot
Comment 15 2010-05-23 03:22:02 PDT
Comment on attachment 56730 [details] Here we go again Clearing flags on attachment: 56730 Committed r60038: <http://trac.webkit.org/changeset/60038>
WebKit Commit Bot
Comment 16 2010-05-23 03:22:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.