Bug 39447 - Removed some reliance on callFame[CodeBlock] by storing CodeBlock in a local variable in the Interpreter.
Summary: Removed some reliance on callFame[CodeBlock] by storing CodeBlock in a local ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-20 14:01 PDT by Geoffrey Garen
Modified: 2010-05-21 03:50 PDT (History)
1 user (show)

See Also:


Attachments
Patch (26.50 KB, patch)
2010-05-20 14:02 PDT, Geoffrey Garen
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2010-05-20 14:01:06 PDT
Removed some reliance on callFame[CodeBlock] by storing CodeBlock in a local variable in the Interpreter.
Comment 1 Geoffrey Garen 2010-05-20 14:02:52 PDT
Created attachment 56627 [details]
Patch
Comment 2 Darin Adler 2010-05-20 14:04:53 PDT
Comment on attachment 56627 [details]
Patch

Any performance data on the effect on the interpreter?

r=me
Comment 3 Geoffrey Garen 2010-05-20 14:15:39 PDT
Slight SunSpider speedup.
Comment 4 Geoffrey Garen 2010-05-20 14:20:22 PDT
Committed r59863: <http://trac.webkit.org/changeset/59863>
Comment 5 Gabor Loki 2010-05-21 03:08:09 PDT
Geoffrey, did you run run-javascriptcore-tests in interpreter mode? On x86 and ARM there are more than 900 regressions ;) . We should rollout the patch until a proper fix is available (probably the fix will influence the performance data).
Comment 6 Gabor Loki 2010-05-21 03:50:14 PDT
The fix is in bug 39480.