WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
39447
Removed some reliance on callFame[CodeBlock] by storing CodeBlock in a local variable in the Interpreter.
https://bugs.webkit.org/show_bug.cgi?id=39447
Summary
Removed some reliance on callFame[CodeBlock] by storing CodeBlock in a local ...
Geoffrey Garen
Reported
2010-05-20 14:01:06 PDT
Removed some reliance on callFame[CodeBlock] by storing CodeBlock in a local variable in the Interpreter.
Attachments
Patch
(26.50 KB, patch)
2010-05-20 14:02 PDT
,
Geoffrey Garen
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Geoffrey Garen
Comment 1
2010-05-20 14:02:52 PDT
Created
attachment 56627
[details]
Patch
Darin Adler
Comment 2
2010-05-20 14:04:53 PDT
Comment on
attachment 56627
[details]
Patch Any performance data on the effect on the interpreter? r=me
Geoffrey Garen
Comment 3
2010-05-20 14:15:39 PDT
Slight SunSpider speedup.
Geoffrey Garen
Comment 4
2010-05-20 14:20:22 PDT
Committed
r59863
: <
http://trac.webkit.org/changeset/59863
>
Gabor Loki
Comment 5
2010-05-21 03:08:09 PDT
Geoffrey, did you run run-javascriptcore-tests in interpreter mode? On x86 and ARM there are more than 900 regressions ;) . We should rollout the patch until a proper fix is available (probably the fix will influence the performance data).
Gabor Loki
Comment 6
2010-05-21 03:50:14 PDT
The fix is in
bug 39480
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug