Bug 39441 - saveAndSetNewPortStateForUpdate sometimes sets an incorrect window.height property
Summary: saveAndSetNewPortStateForUpdate sometimes sets an incorrect window.height pro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Kevin Decker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-20 13:03 PDT by Kevin Decker
Modified: 2010-05-20 14:49 PDT (History)
0 users

See Also:

Attachments
proposed fix (2.46 KB, patch)
2010-05-20 13:06 PDT, Kevin Decker 		no flags Details | Formatted Diff | Diff
now with 64-bit OOP fixes (3.96 KB, patch)
2010-05-20 14:38 PDT, Kevin Decker 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Decker 2010-05-20 13:03:39 PDT 
I noticed through code inspection that saveAndSetNewPortStateForUpdate sometimes sets an incorrect window.height property. This will break plug-ins at non 1.0 scale factors.
Comment 1 Kevin Decker 2010-05-20 13:06:28 PDT 
Created attachment 56623 [details]
proposed fix
Comment 2 Kevin Decker 2010-05-20 14:38:10 PDT 
Created attachment 56633 [details]
now with 64-bit OOP fixes
Comment 3 Anders Carlsson 2010-05-20 14:40:13 PDT 
Comment on attachment 56633 [details]
now with 64-bit OOP fixes

r=me