Bug 39436 – The 'prototype' property on generated Web IDL interfaces should be { DontDelete | ReadOnly }

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Andreas Kling]

According to:
http://www.w3.org/TR/WebIDL/#interface-object

[Andreas Kling]

Created attachment 56611 [details]
Proposed patch, JSC-only

This patch is JSC-only (CodeGeneratorJS.pm)
I'll need some help for the V8 version of this change.

[Alexey Proskuryakov]

This sounds reasonable, but does it match other browsers? A specification alone is rarely a sufficient reason to make a change in WebKit.

[Andreas Kling]

(In reply to comment #2)
> This sounds reasonable, but does it match other browsers?

It matches Firefox. Opera allows delete/overwrite. IE allows overwrite.

[Alexey Proskuryakov]

CC'ing Sam and Maciej, who would probably be the ones to make this call.

[Eric Seidel (no email)]

Comment on attachment 56611 [details]
Proposed patch, JSC-only

+        Need a bug URL (OOPS!)

Will cause the commit to fail, please update.

[Andreas Kling]

Created attachment 56797 [details]
Proposed patch, JSC-only

Updated patch with bug URL.

[Sam Weinig]

Comment on attachment 56797 [details]
Proposed patch, JSC-only

I like it. r=me.

[Andreas Kling]

Comment on attachment 56797 [details]
Proposed patch, JSC-only

Removing cq? since the included test will fail on V8. Need some advice on how to proceed with this patch.

[Alexey Proskuryakov]

Comment on attachment 56797 [details]
Proposed patch, JSC-only

The agreement is that V8 bindings is Google's sole responsibility, and others needn't invest any effort in them. You can find the discussion in webkit-dev archives.

[WebKit Commit Bot]

Comment on attachment 56797 [details]
Proposed patch, JSC-only

Clearing flags on attachment: 56797

Committed r60119: <http://trac.webkit.org/changeset/60119>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.