Bug 39436 - The 'prototype' property on generated Web IDL interfaces should be { DontDelete | ReadOnly }
Summary: The 'prototype' property on generated Web IDL interfaces should be { DontDele...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-20 11:14 PDT by Andreas Kling
Modified: 2010-05-24 20:55 PDT (History)
9 users (show)

See Also:

Attachments
Proposed patch, JSC-only (6.46 KB, patch)
2010-05-20 11:15 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Proposed patch, JSC-only (6.50 KB, patch)
2010-05-22 16:31 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-05-20 11:14:23 PDT 
According to:
http://www.w3.org/TR/WebIDL/#interface-object
Comment 1 Andreas Kling 2010-05-20 11:15:48 PDT 
Created attachment 56611 [details]
Proposed patch, JSC-only

This patch is JSC-only (CodeGeneratorJS.pm)
I'll need some help for the V8 version of this change.
Comment 2 Alexey Proskuryakov 2010-05-20 17:11:25 PDT 
This sounds reasonable, but does it match other browsers? A specification alone is rarely a sufficient reason to make a change in WebKit.
Comment 3 Andreas Kling 2010-05-20 23:14:32 PDT 
(In reply to comment #2)
> This sounds reasonable, but does it match other browsers?

It matches Firefox. Opera allows delete/overwrite. IE allows overwrite.
Comment 4 Alexey Proskuryakov 2010-05-21 10:11:13 PDT 
CC'ing Sam and Maciej, who would probably be the ones to make this call.
Comment 5 Eric Seidel (no email) 2010-05-21 12:06:26 PDT 
Comment on attachment 56611 [details]
Proposed patch, JSC-only

+        Need a bug URL (OOPS!)

Will cause the commit to fail, please update.
Comment 6 Andreas Kling 2010-05-22 16:31:13 PDT 
Created attachment 56797 [details]
Proposed patch, JSC-only

Updated patch with bug URL.
Comment 7 Sam Weinig 2010-05-23 13:58:50 PDT 
Comment on attachment 56797 [details]
Proposed patch, JSC-only

I like it. r=me.
Comment 8 Andreas Kling 2010-05-24 07:04:22 PDT 
Comment on attachment 56797 [details]
Proposed patch, JSC-only

Removing cq? since the included test will fail on V8. Need some advice on how to proceed with this patch.
Comment 9 Alexey Proskuryakov 2010-05-24 09:09:24 PDT 
Comment on attachment 56797 [details]
Proposed patch, JSC-only

The agreement is that V8 bindings is Google's sole responsibility, and others needn't invest any effort in them. You can find the discussion in webkit-dev archives.
Comment 10 WebKit Commit Bot 2010-05-24 20:55:25 PDT 
Comment on attachment 56797 [details]
Proposed patch, JSC-only

Clearing flags on attachment: 56797

Committed r60119: <http://trac.webkit.org/changeset/60119>
Comment 11 WebKit Commit Bot 2010-05-24 20:55:33 PDT 
All reviewed patches have been landed.  Closing bug.