Bug 39423 - Move date/time limit values to DateComponents.h from HTMLInputElement.cpp
Summary: Move date/time limit values to DateComponents.h from HTMLInputElement.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-20 06:36 PDT by Kent Tamura
Modified: 2010-05-26 01:41 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.28 KB, patch)
2010-05-20 06:41 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch (rev.2) (6.45 KB, patch)
2010-05-20 07:03 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch (rev.3) (6.44 KB, patch)
2010-05-20 19:24 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch (rev.4) (6.51 KB, patch)
2010-05-22 08:35 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-05-20 06:36:45 PDT 
Move data/time limit values to DateComponents.h from HTMLInputElement.cpp
Comment 1 Kent Tamura 2010-05-20 06:41:38 PDT 
Created attachment 56591 [details]
Patch
Comment 2 Early Warning System Bot 2010-05-20 06:47:23 PDT 
Attachment 56591 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/2264362
Comment 3 WebKit Review Bot 2010-05-20 06:52:59 PDT 
Attachment 56591 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/2286358
Comment 4 WebKit Review Bot 2010-05-20 06:53:08 PDT 
Attachment 56591 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/2284398
Comment 5 Kent Tamura 2010-05-20 07:03:19 PDT 
Created attachment 56593 [details]
Patch (rev.2)
Comment 6 Kent Tamura 2010-05-20 19:24:47 PDT 
Created attachment 56663 [details]
Patch (rev.3)


---
 3 files changed, 42 insertions(+), 21 deletions(-)
Comment 7 Kent Tamura 2010-05-20 19:26:13 PDT 
(In reply to comment #6)
> Created an attachment (id=56663) [details]
> Patch (rev.3)

It fixed a typo in ChangeLog.
Comment 8 WebKit Review Bot 2010-05-22 02:32:51 PDT 
Attachment 56663 [details] did not build on win:
Build output: http://webkit-commit-queue.appspot.com/results/2283449
Comment 9 Kent Tamura 2010-05-22 08:00:19 PDT 
(In reply to comment #8)
> Attachment 56663 [details] did not build on win:
> Build output: http://webkit-commit-queue.appspot.com/results/2283449

The errors were: Can't initialize non-integer static const field in a class declaration.
I'll change them to inline functions.
Comment 10 Kent Tamura 2010-05-22 08:35:00 PDT 
Created attachment 56778 [details]
Patch (rev.4)
Comment 11 Kent Tamura 2010-05-26 01:41:44 PDT 
Comment on attachment 56778 [details]
Patch (rev.4)

Clearing flags on attachment: 56778

Committed r60222: <http://trac.webkit.org/changeset/60222>
Comment 12 Kent Tamura 2010-05-26 01:41:55 PDT 
All reviewed patches have been landed.  Closing bug.