Bug 39411 - [BREWMP] Don't include POSIX headers in WebCorePrefix.h
Summary: [BREWMP] Don't include POSIX headers in WebCorePrefix.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency tree / graph
 
Reported: 2010-05-20 00:59 PDT by Kwang Yul Seo
Modified: 2010-06-12 20:41 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.46 KB, patch)
2010-05-20 01:03 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-05-20 00:59:43 PDT 
When building for BREW MP, don't include POSIX headers: <fcntl.h>, <pthread.h> and <sys/types.h>.
Comment 1 Kwang Yul Seo 2010-05-20 01:03:18 PDT 
Created attachment 56571 [details]
Patch
Comment 2 Laszlo Gombos 2010-05-24 16:56:22 PDT 
Comment on attachment 56571 [details]
Patch

> +#if !defined(BUILDING_BREWMP__)
>  #include <pthread.h>
> +#endif

Can we use HAVE(PTHREAD_H) as a guard here instead ?
Comment 3 Kwang Yul Seo 2010-05-25 01:44:57 PDT 
(In reply to comment #2)
> Can we use HAVE(PTHREAD_H) as a guard here instead ?

I will try HAVE(XXX_H) and see if other ports build OK.
Comment 4 Kwang Yul Seo 2010-05-25 01:54:45 PDT 
(In reply to comment #3)
> I will try HAVE(XXX_H) and see if other ports build OK.

Oops. It seems we can't use HAVE(WTF_FEATURE) macro in WebCorePrefix.h.
Comment 5 Kent Tamura 2010-06-12 19:04:44 PDT 
Comment on attachment 56571 [details]
Patch

Looks OK.
Comment 6 WebKit Commit Bot 2010-06-12 20:41:29 PDT 
Comment on attachment 56571 [details]
Patch

Clearing flags on attachment: 56571

Committed r61074: <http://trac.webkit.org/changeset/61074>
Comment 7 WebKit Commit Bot 2010-06-12 20:41:34 PDT 
All reviewed patches have been landed.  Closing bug.