Bug 39402 – [chromium] disable spelling suggestions if spellcheck=false

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

[chromium] disable spelling suggestions if spellcheck=false

[Tony Chang]

Created attachment 56558 [details]
Patch

[Kent Tamura]

Comment on attachment 56558 [details]
Patch

WebKit/chromium/src/ContextMenuClientImpl.cpp:205
 +              data.isSpellCheckingEnabled = true;
Should we leave this line in a case of no misspelledWord?

[Tony Chang]

(In reply to comment #2)
> (From update of attachment 56558 [details])
> WebKit/chromium/src/ContextMenuClientImpl.cpp:205
>  +              data.isSpellCheckingEnabled = true;
> Should we leave this line in a case of no misspelledWord?

I left it in to be consistent with Safari.  This means that the context menu will still show a check mark by "Spellchecking in this field".  I did it this way in Safari because you can imagine a div with spellchecking enabled, with a single span inside it that has spellchecking disabled.  It seems more consistent to treat the whole field as "spellcheck enabled" even if you click in the span.  I think it would be confusing if the check mark changed depending on which node you happened to click on within a single content editable node.

[Kent Tamura]

Comment on attachment 56558 [details]
Patch

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 56558 [details] [details])
> > WebKit/chromium/src/ContextMenuClientImpl.cpp:205
> >  +              data.isSpellCheckingEnabled = true;
> > Should we leave this line in a case of no misspelledWord?
> 
> I left it in to be consistent with Safari.  This means that the context menu will still show a check mark by "Spellchecking in this field".  I did it this way in Safari because you can imagine a div with spellchecking enabled, with a single span inside it that has spellchecking disabled.  It seems more consistent to treat the whole field as "spellcheck enabled" even if you click in the span.  I think it would be confusing if the check mark changed depending on which node you happened to click on within a single content editable node.

Ok, that's reasonable.

[Tony Chang]

Committed r59819: <http://trac.webkit.org/changeset/59819>