Bug 39401 - [BREWMP] Add EventLoop
Summary: [BREWMP] Add EventLoop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency tree / graph
 
Reported: 2010-05-19 21:13 PDT by Kwang Yul Seo
Modified: 2010-06-09 09:59 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.36 KB, patch)
2010-05-19 21:14 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
Revised patch (2.39 KB, patch)
2010-05-20 00:45 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-05-19 21:13:02 PDT 
BREW MP does not have an explicit event loop. Add dummy EventLoop::cycle.
Comment 1 Kwang Yul Seo 2010-05-19 21:14:09 PDT 
Created attachment 56557 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-05-20 00:32:16 PDT 
Comment on attachment 56557 [details]
Patch

You need to remove the "No new tests (OOPS!)" line and replace it with either tests or reasons for no tests.  In this case it's rather obvious that no tests are needed, but that second OOPS! will prevent the bot from being able to land this.
Comment 3 Kwang Yul Seo 2010-05-20 00:45:01 PDT 
Created attachment 56570 [details]
Revised patch

Removed "No new tests. (OOPS!)"
Comment 4 Eric Seidel (no email) 2010-06-02 02:25:39 PDT 
Comment on attachment 56557 [details]
Patch

Cleared Eric Seidel's review+ from obsolete attachment 56557 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 5 Kent Tamura 2010-06-08 23:56:46 PDT 
Comment on attachment 56570 [details]
Revised patch

Looks OK though I don't know why BREW MP needs no explicit event loop.
Comment 6 Kwang Yul Seo 2010-06-08 23:59:00 PDT 
(In reply to comment #5)
> (From update of attachment 56570 [details])
> Looks OK though I don't know why BREW MP needs no explicit event loop.

Thanks. Brew MP does not have have any programmable event loop.
Comment 7 WebKit Commit Bot 2010-06-09 09:59:07 PDT 
Comment on attachment 56570 [details]
Revised patch

Clearing flags on attachment: 56570

Committed r60896: <http://trac.webkit.org/changeset/60896>
Comment 8 WebKit Commit Bot 2010-06-09 09:59:13 PDT 
All reviewed patches have been landed.  Closing bug.