RESOLVED FIXED 39399
Move responsibility for verifying constructors return objects from the caller to the callee. 
https://bugs.webkit.org/show_bug.cgi?id=39399
Summary Move responsibility for verifying constructors return objects from the caller...
Gavin Barraclough
Reported 2010-05-19 20:48:44 PDT
This is a necessary set to move object creation from caller to callee.
Attachments
The patch (16.84 KB, patch)
2010-05-19 20:50 PDT, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-05-19 20:50:12 PDT
Created attachment 56554 [details] The patch
WebKit Review Bot
Comment 2 2010-05-19 20:51:15 PDT
Attachment 56554 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1545: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2010-05-19 21:36:14 PDT
Comment on attachment 56554 [details] The patch Please fix stylebot comment. Please change to a name that begins with op_ret, for the sake of global search. We discussed op_ret_object or op_ret_object_or_this on IRC.
Gavin Barraclough
Comment 4 2010-05-19 21:57:41 PDT
Transmitting file data ........... Committed revision 59817.
Note You need to log in before you can comment on or make changes to this bug.