WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
39393
JSFunction need not be a subclass of InternalFunction.
https://bugs.webkit.org/show_bug.cgi?id=39393
Summary
JSFunction need not be a subclass of InternalFunction.
Gavin Barraclough
Reported
2010-05-19 17:49:49 PDT
This may prevent us from introducing a more useful parent class to JSFunction, e.g. a JSObject that holds an executable, which could also reference an eval or program executable.
Attachments
The patch
(15.57 KB, patch)
2010-05-19 17:51 PDT
,
Gavin Barraclough
oliver
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2010-05-19 17:51:13 PDT
Created
attachment 56541
[details]
The patch
WebKit Review Bot
Comment 2
2010-05-19 17:52:02 PDT
Attachment 56541
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/runtime/FunctionPrototype.cpp:90: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 3
2010-05-19 17:55:25 PDT
Comment on
attachment 56541
[details]
The patch r=me if you fix the style error
Gavin Barraclough
Comment 4
2010-05-19 18:01:17 PDT
Transmitting file data ........... Committed revision 59800.
Yong Li
Comment 5
2010-05-31 15:26:27 PDT
this breaks something like this: if (!value.inherits(&InternalFunction::info)) {
Yong Li
Comment 6
2010-05-31 15:33:43 PDT
bug created:
bug 39971
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug