Bug 39370 – [chromium] Fix slider status when buffering

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Victoria Kirst]

When you load a video, the slider shows the entire video has been buffered, when only a small portion of it has been buffered.

[Victoria Kirst]

Created attachment 56511 [details]
Patch

[Hin-Chung Lam]

Victoria is working with me on HTML5 video in Chromium. This change looks good to me.

[David Levin]

Comment on attachment 56511 [details]
Patch

Thanks Alpha for looking it over.

Just a few minor nits to address.

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog

> +
> +        * rendering/RenderMediaControlsChromium.cpp:
> +        (WebCore::paintMediaSlider):
> +        Added logic to align the buffering bar with the thumb. Half of the thumb image is transparent, so the buffer bar is adjusted to fill in this gap.

ChangeLog entries tend to wrap text somewhere around 80 columns.


> diff --git a/WebCore/rendering/RenderMediaControlsChromium.cpp b/WebCore/rendering/RenderMediaControlsChromium.cpp
> +static Image* getMediaSliderThumb()
> +{
> +    static Image* mediaSliderThumb  = platformResource("mediaSliderThumb");

Two spaces before =

> +
> +    double bufferedWidth = 0.0;
> +    if (mediaElement->percentLoaded() > 0.0) {
> +        // Account for width of slider thumb

Please add a period to the end of the comment.

> +        Image* mediaSliderThumb = getMediaSliderThumb();
> +        double thumbWidth = mediaSliderThumb->width() / 2.0 + 1.0;
> +        double rectWidth = bufferedRect.width() - thumbWidth;
> +        if (rectWidth < 0)
> +            rectWidth = 0;

I'm not sure why you initialized "double bufferedWidth" with 0.0 above but are using 0 here. (It doesn't matter but inconsistency raises flags for me.)

[Victoria Kirst]

Created attachment 56604 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 56604 [details]
Patch

Clearing flags on attachment: 56604

Committed r59932: <http://trac.webkit.org/changeset/59932>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.