Move view-related functions from Frame to FrameView
Created attachment 56500 [details]
Attachment 56500 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/2265334
Attachment 56500 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/2284350
Comment on attachment 56500 [details]
+ multiplier *= view->textZoomFactor();
much cleaner, thanks.
+ float zoomFactor = pageZoomFactor(this);
MUCH cleaner. Thanks again!
This is a behavior change. We didn't use to bother to layout when the view didn't exist. Is this intentional?
+ int m_borderX;
This is destined to be an IntSize in a later patch. :)
+ return -1;
(In reply to comment #4)
> + document->updateLayoutIgnorePendingStylesheets();
> This is a behavior change. We didn't use to bother to layout when the view didn't exist. Is this intentional?
It was intentional. I think it's safer to call the layout update function before looking at anything, including the view's existence.
> + int m_borderX;
> This is destined to be an IntSize in a later patch. :)
I thought the same thing.
> + return -1;
Just following the design of this EFL function. They made it return -1 when there is no frame. I don't understand it -- that's the downside of each port having its own API. Different quirks.
Committed r60104: <http://trac.webkit.org/changeset/60104>
http://trac.webkit.org/changeset/60104 might have broken Qt Linux ARMv5 Release
The following changes are on the blame list:
I think this change broke Chromium's compile on all platforms too.
(In reply to comment #8)
> I think this change broke Chromium's compile on all platforms too.
Has it been fixed yet? Everything looks OK on <http://build.webkit.org/waterfall> at this point, so maybe I fixed it or someone else did. The fix should be simple if it hasn't been done yet.
Yup, tc fixed it last night in r60111. Thanks for following up!