WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
39358
Extra processesArguments() calls in Document::processViewport
https://bugs.webkit.org/show_bug.cgi?id=39358
Summary
Extra processesArguments() calls in Document::processViewport
Jesus Sanchez-Palencia
Reported
2010-05-19 06:58:57 PDT
The viewport arguments are only needed when there is a frame->page(), therefore we don't need to always call processArguments().
Attachments
patch
(2.08 KB, patch)
2010-05-19 07:05 PDT
,
Jesus Sanchez-Palencia
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jesus Sanchez-Palencia
Comment 1
2010-05-19 07:05:26 PDT
Created
attachment 56485
[details]
patch
Eric Seidel (no email)
Comment 2
2010-05-20 00:53:37 PDT
Comment on
attachment 56485
[details]
patch Assuming proceessArguments has no observable side-effects, sure.
Jesus Sanchez-Palencia
Comment 3
2010-05-20 07:41:26 PDT
Comment on
attachment 56485
[details]
patch Thanks! Adding to the cq+ .
WebKit Commit Bot
Comment 4
2010-05-21 07:21:47 PDT
Comment on
attachment 56485
[details]
patch Clearing flags on attachment: 56485 Committed
r59931
: <
http://trac.webkit.org/changeset/59931
>
WebKit Commit Bot
Comment 5
2010-05-21 07:21:52 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug