Bug 39358 - Extra processesArguments() calls in Document::processViewport
Summary: Extra processesArguments() calls in Document::processViewport
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jesus Sanchez-Palencia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-19 06:58 PDT by Jesus Sanchez-Palencia
Modified: 2010-05-21 07:21 PDT (History)
1 user (show)

See Also:

Attachments
patch (2.08 KB, patch)
2010-05-19 07:05 PDT, Jesus Sanchez-Palencia 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesus Sanchez-Palencia 2010-05-19 06:58:57 PDT 
The viewport arguments are only needed when there is a frame->page(), therefore we don't need to always call processArguments().
Comment 1 Jesus Sanchez-Palencia 2010-05-19 07:05:26 PDT 
Created attachment 56485 [details]
patch
Comment 2 Eric Seidel (no email) 2010-05-20 00:53:37 PDT 
Comment on attachment 56485 [details]
patch

Assuming proceessArguments has no observable side-effects, sure.
Comment 3 Jesus Sanchez-Palencia 2010-05-20 07:41:26 PDT 
Comment on attachment 56485 [details]
patch

Thanks! Adding to the cq+ .
Comment 4 WebKit Commit Bot 2010-05-21 07:21:47 PDT 
Comment on attachment 56485 [details]
patch

Clearing flags on attachment: 56485

Committed r59931: <http://trac.webkit.org/changeset/59931>
Comment 5 WebKit Commit Bot 2010-05-21 07:21:52 PDT 
All reviewed patches have been landed.  Closing bug.