Bug 39322 - [GTK] DragClientGtk::startDrag leaks GdkEvents
Summary: [GTK] DragClientGtk::startDrag leaks GdkEvents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 30623
  Show dependency tree / graph
 
Reported: 2010-05-18 14:38 PDT by Martin Robinson
Modified: 2010-05-18 15:15 PDT (History)
0 users

See Also:

Attachments
Fix memory leak (2.17 KB, patch)
2010-05-18 14:40 PDT, Martin Robinson 		xan.lopez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-05-18 14:38:00 PDT 
SSIA
Comment 1 Martin Robinson 2010-05-18 14:40:28 PDT 
Created attachment 56414 [details]
Fix memory leak
Comment 2 Xan Lopez 2010-05-18 14:46:00 PDT 
Comment on attachment 56414 [details]
Fix memory leak

>+    GdkWindow* window = gtk_widget_get_window(GTK_WIDGET(m_webView));
>+    g_object_ref(window); // This will be decremented by gdk_event_free() below.
>+    event->button.window = gtk_widget_get_window(GTK_WIDGET(m_webView));

just event->button.window = window; ?

r=me
Comment 3 Martin Robinson 2010-05-18 15:15:13 PDT 
Committed r59714: <http://trac.webkit.org/changeset/59714>