Bug 39303 - Web Inspector: fix some localization issues
Summary: Web Inspector: fix some localization issues
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-18 11:42 PDT by Timothy Hatcher
Modified: 2010-05-18 13:23 PDT (History)
8 users (show)

See Also:


Attachments
Proposed patch (36.10 KB, patch)
2010-05-18 12:24 PDT, Timothy Hatcher
aroben: review+
timothy: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2010-05-18 11:42:22 PDT
There are a handful of localization issues that need fixed.
Comment 1 Timothy Hatcher 2010-05-18 12:24:49 PDT
Created attachment 56400 [details]
Proposed patch
Comment 2 Adam Roben (:aroben) 2010-05-18 13:14:33 PDT
Comment on attachment 56400 [details]
Proposed patch

WebCore/inspector/front-end/TimelinePanel.js:899
 +                  contentHelper._appendTextRow(WebInspector.UIString("Timer Id"), this.data.timerId);
I'm surprised "Id" isn't "ID".

WebCore/inspector/front-end/TimelinePanel.js:921
 +                      contentHelper._appendTextRow(WebInspector.UIString("Mime Type"), this.data.mimeType);
Should "Mime" be "MIME"?

Seems like the number-formatting functions should move off of the Number object and just always use WebInspector.UIString.

r=me
Comment 3 Timothy Hatcher 2010-05-18 13:23:52 PDT
Landed in r59688.