Bug 39287 - REGRESSION(59637): interpreter build broke
Summary: REGRESSION(59637): interpreter build broke
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-18 05:22 PDT by Csaba Osztrogonác
Modified: 2010-05-18 12:12 PDT (History)
6 users (show)

See Also:


Attachments
interpreter fix (4.18 KB, patch)
2010-05-18 07:08 PDT, Gabor Loki
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-05-18 05:22:04 PDT
r59637 broke interpreter build, becauase class NativeExecutable is
declared in #if ENABLE(JIT) block (JavaScriptCore/runtime/Executable.h),
but it is used outside of ENABLE(JIT) block.

error message:
---------------
In file included from ../../../JavaScriptCore/runtime/Identifier.h:24,
from ../../../JavaScriptCore/runtime/Structure.h:29,
from ../../../JavaScriptCore/runtime/JSCell.h:30,
from ../../../JavaScriptCore/runtime/JSAPIValueWrapper.h:26,
from ../../../JavaScriptCore/API/APICast.h:29,
from ../../../JavaScriptCore/API/JSBase.cpp:30:
../../../JavaScriptCore/runtime/JSGlobalData.h:182: error: ‘NativeExecutable’ was not declared in this scope
../../../JavaScriptCore/runtime/JSGlobalData.h:182: error: template argument 1 is invalid
../../../JavaScriptCore/runtime/JSGlobalData.h:182: error: template argument 2 is invalid
../../../JavaScriptCore/runtime/JSGlobalData.h:182: error: template argument 5 is invalid
../../../JavaScriptCore/runtime/JSGlobalData.h:184: error: ‘NativeExecutable’ was not declared in this scope
../../../JavaScriptCore/runtime/JSGlobalData.h:184: error: template argument 1 is invalid
make[1]: *** [obj/release/JSBase.o] Error 1
Comment 1 Gabor Loki 2010-05-18 07:08:46 PDT
Created attachment 56370 [details]
interpreter fix
Comment 2 Gabor Loki 2010-05-18 11:33:38 PDT
Committed revision 59676.
Comment 3 WebKit Review Bot 2010-05-18 12:09:50 PDT
http://trac.webkit.org/changeset/59676 might have broken Qt Linux ARMv5 Release and Qt Linux ARMv7 Release
Comment 4 Csaba Osztrogonác 2010-05-18 12:12:20 PDT
(In reply to comment #3)
> http://trac.webkit.org/changeset/59676 might have broken Qt Linux ARMv5 Release and Qt Linux ARMv7 Release

False positive alarm, it caused by slave lost.