Bug 39269 – [Chromium] Windows: Determinate progress bar should have glossy overlay

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Hajime Morrita]

On Windows Vista with Aero, determinate progress bars are drawn with glossy overlay.
We should have it for <progress> on Windows Chromium.

[Hajime Morrita]

Chromium side is http://crbug.com/44430

[Hajime Morrita]

Created attachment 56327 [details]
patch v0

[Kent Tamura]

Comment on attachment 56327 [details]
patch v0



WebCore/platform/chromium/ChromiumBridge.h:228
 +              GraphicsContext*, const IntRect& barRect, const IntRect& valueRect, bool determinate, double time);
The name "time" is unclear.  Maybe "secondsSinceEpoch"?


WebCore/rendering/RenderThemeChromiumWin.cpp:672
 +      // So here we can return arbitrary value.
The value must be greater than 0, not arbitrary.




WebKit/chromium/public/WebThemeEngine.h:81
 +          bool determinate, double time) {}
Ditto for "time"


WebKit/chromium/src/ChromiumBridge.cpp:683
 +      GraphicsContext* gc, const IntRect& barRect, const IntRect& valueRect, bool determinate, double time)
ditto.

WebKit/chromium/src/ChromiumBridge.cpp:686
 +          gc->platformContext()->canvas(), barRect, valueRect, determinate, time);
ditto.

[Hajime Morrita]

Created attachment 56344 [details]
patch v1

[Hajime Morrita]

Created attachment 56347 [details]
patch v2

[Hajime Morrita]

Hi Kent-san, thank you for reviewing quickly!
I updated the patch to take the feedback.

> WebCore/platform/chromium/ChromiumBridge.h:228
>  +              GraphicsContext*, const IntRect& barRect, const IntRect& valueRect, bool determinate, double time);
> The name "time" is unclear.  Maybe "secondsSinceEpoch"?
Fixed to replace with "animatedSeconds". I fixed other part too.

This patch also chagnes the value from 
absolute seconds (WTF::currentTime()) to 
relative seconds from animation started to 
make the animation starts from left side.

[Kent Tamura]

Comment on attachment 56347 [details]
patch v2

Please update ChangeLog.
It has no entry for RenderProgress.h.

[Hajime Morrita]

Created attachment 56359 [details]
patch v3; update ChangeLog

[Hajime Morrita]

> Please update ChangeLog.
> It has no entry for RenderProgress.h.
Oops. I'm sorry for that. I've updated the patch to fix it.

[Kent Tamura]

Can we close this?

[Hajime Morrita]

Committed r59733: <http://trac.webkit.org/changeset/59733>
Closing bug.