Bug 39247 - Move rarely used data members to the rare structures, thus saving memory.
Summary: Move rarely used data members to the rare structures, thus saving memory.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-05-17 15:47 PDT by Anders Carlsson
Modified: 2010-05-17 16:35 PDT (History)
3 users (show)

See Also:


Attachments
Patch (21.73 KB, patch)
2010-05-17 15:59 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-05-17 15:47:03 PDT
Move rarely used data members to the rare structures, thus saving memory.
Comment 1 Anders Carlsson 2010-05-17 15:59:22 PDT
Created attachment 56282 [details]
Patch
Comment 2 Anders Carlsson 2010-05-17 15:59:46 PDT
<rdar://problem/7994707>
Comment 3 WebKit Review Bot 2010-05-17 16:00:24 PDT
Attachment 56282 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/rendering/style/RenderStyle.cpp:382:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/rendering/style/RenderStyle.cpp:383:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/rendering/style/RenderStyle.cpp:399:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/rendering/style/RenderStyle.cpp:465:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 4 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Anders Carlsson 2010-05-17 16:04:31 PDT
Committed r59629: <http://trac.webkit.org/changeset/59629>
Comment 5 Eric Seidel (no email) 2010-05-17 16:27:30 PDT
A Qt test crashed after this commit:
http://build.webkit.org/results/Qt%20Linux%20Release/r59629%20(11910)/http/tests/misc/font-face-in-multiple-segmented-faces-stderr.txt

It might just be a flaky test though.  Waiting for another roll.
Comment 6 Eric Seidel (no email) 2010-05-17 16:35:38 PDT
Rolled green.