Bug 39246 – test-webkitpy errors out on Windows Build Bot

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Eric Seidel (no email)]

test-webkitpy errors out on Windows Build Bot

test-webkitpy passes on the win-ews bot, but not on the build bot.  Not sure why yet.

======================================================================
ERROR: Validate that it is safe to pass unicode() objects
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbot/slave/win-release-tests/build/WebKitTools/Scripts/webkitpy/common/system/executive_unittest.py", line 56, in test_run_command_with_unicode
    output = executive.run_command(["echo", "-n", unicode_tor])
  File "/home/buildbot/slave/win-release-tests/build/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 277, in run_command
    close_fds=self._should_close_fds())
  File "/usr/lib/python2.5/subprocess.py", line 594, in __init__
    errread, errwrite)
  File "/usr/lib/python2.5/subprocess.py", line 1091, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

======================================================================
ERROR: test_handled_error (webkitpy.tool.bot.queueengine_unittest.QueueEngineTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbot/slave/win-release-tests/build/WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py", line 179, in tearDown
    shutil.rmtree(self.temp_dir)
  File "/usr/lib/python2.5/shutil.py", line 178, in rmtree
    onerror(os.rmdir, path, sys.exc_info())
  File "/usr/lib/python2.5/shutil.py", line 176, in rmtree
    os.rmdir(path)
OSError: [Errno 90] Directory not empty: '/cygdrive/c/DOCUME~1/buildbot/LOCALS~1/Temp/tmp17_Pucwork_queue_test_logs'

======================================================================
ERROR: test_not_safe_to_proceed (webkitpy.tool.bot.queueengine_unittest.QueueEngineTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbot/slave/win-release-tests/build/WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py", line 179, in tearDown
    shutil.rmtree(self.temp_dir)
  File "/usr/lib/python2.5/shutil.py", line 178, in rmtree
    onerror(os.rmdir, path, sys.exc_info())
  File "/usr/lib/python2.5/shutil.py", line 176, in rmtree
    os.rmdir(path)
OSError: [Errno 90] Directory not empty: '/cygdrive/c/DOCUME~1/buildbot/LOCALS~1/Temp/tmpG2o3m1work_queue_test_logs'

======================================================================
ERROR: test_trivial (webkitpy.tool.bot.queueengine_unittest.QueueEngineTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbot/slave/win-release-tests/build/WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py", line 179, in tearDown
    shutil.rmtree(self.temp_dir)
  File "/usr/lib/python2.5/shutil.py", line 178, in rmtree
    onerror(os.rmdir, path, sys.exc_info())
  File "/usr/lib/python2.5/shutil.py", line 176, in rmtree
    os.rmdir(path)
OSError: [Errno 90] Directory not empty: '/cygdrive/c/DOCUME~1/buildbot/LOCALS~1/Temp/tmpcJAhcUwork_queue_test_logs'

======================================================================
ERROR: test_unexpected_error (webkitpy.tool.bot.queueengine_unittest.QueueEngineTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbot/slave/win-release-tests/build/WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py", line 179, in tearDown
    shutil.rmtree(self.temp_dir)
  File "/usr/lib/python2.5/shutil.py", line 178, in rmtree
    onerror(os.rmdir, path, sys.exc_info())
  File "/usr/lib/python2.5/shutil.py", line 176, in rmtree
    os.rmdir(path)
OSError: [Errno 90] Directory not empty: '/cygdrive/c/DOCUME~1/buildbot/LOCALS~1/Temp/tmpKP2odhwork_queue_test_logs'

----------------------------------------------------------------------

[Adam Roben (:aroben)]

(In reply to comment #0)
> ERROR: test_handled_error (webkitpy.tool.bot.queueengine_unittest.QueueEngineTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/home/buildbot/slave/win-release-tests/build/WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py", line 179, in tearDown
>     shutil.rmtree(self.temp_dir)
>   File "/usr/lib/python2.5/shutil.py", line 178, in rmtree
>     onerror(os.rmdir, path, sys.exc_info())
>   File "/usr/lib/python2.5/shutil.py", line 176, in rmtree
>     os.rmdir(path)
> OSError: [Errno 90] Directory not empty: '/cygdrive/c/DOCUME~1/buildbot/LOCALS~1/Temp/tmp17_Pucwork_queue_test_logs'

I'm guessing we're deleting a temporary directory after the process that was using it has quit? If so, we might just need to wait/sleep for a second in order to allow the process to *really* quit.

[Adam Roben (:aroben)]

This seems to have gotten fixed at some point.