Bug 39242 - WinEWS should build Debug instead of Release
Summary: WinEWS should build Debug instead of Release
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 39197
Blocks:
  Show dependency tree / graph
 
Reported: 2010-05-17 14:58 PDT by Eric Seidel (no email)
Modified: 2010-05-19 22:38 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2010-05-17 15:00 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-05-17 14:58:38 PDT 
WinEWS should build Debug instead of Release
Comment 1 Eric Seidel (no email) 2010-05-17 15:00:41 PDT 
Created attachment 56274 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-05-17 15:01:59 PDT 
Comment on attachment 56274 [details]
Patch

The WinEWS automatically restarts itself (and does a clean build) every 50 builds, so it will pick this up automatically once it lands.
Comment 3 Eric Seidel (no email) 2010-05-17 15:02:31 PDT 
I wonder if I need to make the same change to the cr-win-ews.
Comment 4 Eric Seidel (no email) 2010-05-17 15:02:52 PDT 
We also could just move the WinEWS to a EC2 machine with 64-bit windows.
Comment 5 Mark Rowe (bdash) 2010-05-17 15:13:26 PDT 
Release builds on Windows tend to be substantially slower to link than Debug builds due to link-time code generation, so this is probably a good change even if the builder was running 64-bit Windows.
Comment 6 Brian Weinstein 2010-05-17 15:51:22 PDT 
(In reply to comment #5)
> Release builds on Windows tend to be substantially slower to link than Debug builds due to link-time code generation, so this is probably a good change even if the builder was running 64-bit Windows.

I agree with this - look at:

http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/14330

and compare to

http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/15539

They are both builds from the same change, and the release build took 17 minutes (almost all linking), while the debug build took 1.5 minutes.

We should definitely be using debug for now.
Comment 7 Adam Roben (:aroben) 2010-05-18 06:53:08 PDT 
Why does this bug depend on bug 39197?
Comment 8 Adam Roben (:aroben) 2010-05-18 06:53:37 PDT 
Comment on attachment 56274 [details]
Patch

r=me
Comment 9 Eric Seidel (no email) 2010-05-18 11:18:39 PDT 
(In reply to comment #7)
> Why does this bug depend on bug 39197?

I was just trying to relate the two.  I often want a "related bugs" field in bugzilla which doesn't imply dependency.
Comment 10 WebKit Commit Bot 2010-05-19 22:38:23 PDT 
Comment on attachment 56274 [details]
Patch

Clearing flags on attachment: 56274

Committed r59821: <http://trac.webkit.org/changeset/59821>
Comment 11 WebKit Commit Bot 2010-05-19 22:38:30 PDT 
All reviewed patches have been landed.  Closing bug.