Bug 39222 - V8 code generator does not add ENABLE guards around attribute getters and setters
Summary: V8 code generator does not add ENABLE guards around attribute getters and set...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 39210
  Show dependency tree / graph
 
Reported: 2010-05-17 09:31 PDT by Steve Block
Modified: 2010-05-19 03:48 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.39 KB, patch)
2010-05-17 13:01 PDT, Steve Block 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-05-17 09:31:56 PDT 
The V8 code generator does not add ENABLE guards around the static functions used to implement generated attribute getters and setters. This means that when a class has methods which are guarded by an enable flag, and that flag is disabled, the generated code will reference these methods without a guard, causing compile errors.

For example, if TOUCH_EVENTS are disabled, ontouchstartAttrGetter() in V8DOMWindow.cpp is generated without guards and calls DOMWindow::ontouchstart(), which is guarded by ENABLE(TOUCH_EVENTS)
Comment 1 Steve Block 2010-05-17 13:01:23 PDT 
Created attachment 56258 [details]
Patch
Comment 2 Nate Chapin 2010-05-17 13:10:41 PDT 
Comment on attachment 56258 [details]
Patch

Ok.
Comment 3 WebKit Commit Bot 2010-05-19 03:48:47 PDT 
Comment on attachment 56258 [details]
Patch

Clearing flags on attachment: 56258

Committed r59757: <http://trac.webkit.org/changeset/59757>
Comment 4 WebKit Commit Bot 2010-05-19 03:48:54 PDT 
All reviewed patches have been landed.  Closing bug.