[Qt] Tiled backing store tiles sometimes flicker when exiting a zoom animation

[Antti Koivisto]

Tiles some times flicker when exiting a zoom animation. This happens as a result of the visible rectangle being momentarily out of sync.

[Antti Koivisto]

Created attachment 56244 [details]
patch

Instead of updating the visible rect by explicitly setting it, pull it through the client and recompute in the WebKit level.

[Kenneth Rohde Christiansen]

Comment on attachment 56244 [details]
patch

Looks fine, thought I would like a better name for checkVisibleRectChanged();

Maybe adjustVisibleRect? or something similar

[Antti Koivisto]

with the suggested rename:

Sending        WebCore/ChangeLog
Sending        WebCore/page/ChromeClient.h
Sending        WebCore/page/Frame.cpp
Sending        WebCore/page/Frame.h
Sending        WebCore/platform/graphics/TiledBackingStore.cpp
Sending        WebCore/platform/graphics/TiledBackingStore.h
Sending        WebCore/platform/graphics/TiledBackingStoreClient.h
Sending        WebKit/qt/Api/qgraphicswebview.cpp
Sending        WebKit/qt/ChangeLog
Sending        WebKit/qt/WebCoreSupport/ChromeClientQt.cpp
Sending        WebKit/qt/WebCoreSupport/ChromeClientQt.h
Transmitting file data ...........
Committed revision 59611.

Sending        WebCore/ChangeLog
Sending        WebCore/platform/qt/QWebPageClient.h
Transmitting file data ..
Committed revision 59612.

[Simon Hausmann]

Revision r59611 cherry-picked into qtwebkit-2.0 with commit 9c30b2733c9727c5313df46bcf01cb9cdefbd5a1

[Simon Hausmann]

(In reply to comment #4)
> Revision r59611 cherry-picked into qtwebkit-2.0 with commit 9c30b2733c9727c5313df46bcf01cb9cdefbd5a1

r59612 is also included in the same sha1.

[Andreas Kling]

*** Bug 39154 has been marked as a duplicate of this bug. ***