Bug 39216 - Hook Chromium's WebIndexedDatabaseImpl up to IndexedDatabaseImpl
Summary: Hook Chromium's WebIndexedDatabaseImpl up to IndexedDatabaseImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-17 07:01 PDT by Jeremy Orlow
Modified: 2010-05-19 03:19 PDT (History)
8 users (show)

See Also:

Attachments
Patch (26.15 KB, patch)
2010-05-17 07:12 PDT, Jeremy Orlow 		no flags Details | Formatted Diff | Diff
Patch (26.15 KB, patch)
2010-05-17 08:47 PDT, Jeremy Orlow 		no flags Details | Formatted Diff | Diff
Patch (29.51 KB, patch)
2010-05-18 03:25 PDT, Jeremy Orlow 		no flags Details | Formatted Diff | Diff
Patch (29.54 KB, patch)
2010-05-18 04:28 PDT, Jeremy Orlow 		fishd: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2010-05-17 07:01:39 PDT 
find . | grep CMake
Comment 1 Jeremy Orlow 2010-05-17 07:03:13 PDT 
Oops...user error.
Comment 2 Jeremy Orlow 2010-05-17 07:12:33 PDT 
Created attachment 56239 [details]
Patch
Comment 3 WebKit Review Bot 2010-05-17 07:49:08 PDT 
Attachment 56239 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/2269238
Comment 4 Jeremy Orlow 2010-05-17 08:47:33 PDT 
Created attachment 56245 [details]
Patch
Comment 5 Jeremy Orlow 2010-05-17 09:55:07 PDT 
+ Darin since it is mostly WebKit API changes (though I think any Chromium reviewer could look at it)
Comment 6 Nate Chapin 2010-05-17 10:05:33 PDT 
Comment on attachment 56245 [details]
Patch

> -    virtual void open(const String& name, const String& description, bool modifyDatabase, PassRefPtr<IDBCallbacks>, Frame*, ExceptionCode&);
> +    virtual void open(const String& name, const String& description, bool modifyDatabase, PassRefPtr<IDBCallbacks>, const String& origin, Frame*, ExceptionCode&);

Here and a bunch of other places, you're passing around the origin as a String/WebString. It probably makes more sense to use SecurityOrigin/WebSecurityOrigin.

That was the main thing I saw, but I'm not terribly confident on my understanding of the Chromium API layering and organization, so fishd's opinion will be appreciated. :)
Comment 7 Jeremy Orlow 2010-05-18 03:25:13 PDT 
Created attachment 56349 [details]
Patch
Comment 8 Jeremy Orlow 2010-05-18 03:29:08 PDT 
Nate: Fixed the issues you raised.

FishD: Please take a look.
Comment 9 WebKit Review Bot 2010-05-18 04:25:02 PDT 
Attachment 56349 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/2293260
Comment 10 Jeremy Orlow 2010-05-18 04:28:31 PDT 
Created attachment 56360 [details]
Patch
Comment 11 Darin Fisher (:fishd, Google) 2010-05-18 08:04:39 PDT 
Comment on attachment 56360 [details]
Patch

WebKit/chromium/src/WebIndexedDatabaseImpl.cpp:63
 +      
nit: extraneous new line

WebKit/chromium/src/WebIDBDatabaseImpl.cpp:51
 +  
nit: extraneous new line

WebKit/chromium/src/WebIDBCallbacksImpl.h:61
 +  
nit: extraneous new line
Comment 12 Jeremy Orlow 2010-05-19 03:04:53 PDT 
Committed r59755: <http://trac.webkit.org/changeset/59755>
Comment 13 WebKit Review Bot 2010-05-19 03:19:18 PDT 
http://trac.webkit.org/changeset/59755 might have broken Chromium Win Release