Bug 39205 - [GStreamer] enable gst support if USE_GSTREAMER macro is defined
Summary: [GStreamer] enable gst support if USE_GSTREAMER macro is defined
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 39202
  Show dependency tree / graph
 
Reported: 2010-05-17 01:20 PDT by Philippe Normand
Modified: 2010-05-20 01:45 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (2.25 KB, patch)
2010-05-17 01:31 PDT, Philippe Normand 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-05-17 01:20:22 PDT 
Currently MediaPlayer.cpp includes MediaPlayerPrivateGStreamer only for the GTK port. It would be more convenient to enable the player include and creation only if USE_GSTREAMER macro is defined.
Comment 1 Philippe Normand 2010-05-17 01:31:09 PDT 
Created attachment 56221 [details]
proposed patch
Comment 2 Eric Seidel (no email) 2010-05-20 01:04:50 PDT 
Comment on attachment 56221 [details]
proposed patch

ok.  rs=me.
Comment 3 Eric Seidel (no email) 2010-05-20 01:05:27 PDT 
You should CC some of the media folks on your bugs so they get to see media changes go by.  (at least until they tell you not to CC them). :)
Comment 4 David Levin 2010-05-20 01:08:32 PDT 
Removing atwilson and adding scherkus to get the video person :).
Comment 5 Eric Seidel (no email) 2010-05-20 01:09:35 PDT 
Sorry, I'm remembering my video folks wrong.  I added atwilson to a few other media bugs by mistake then too. :(
Comment 6 Philippe Normand 2010-05-20 01:45:55 PDT 
Landed in http://trac.webkit.org/changeset/59825
Thanks :)