Bug 39196 – Rollout changeset 59274 (as requested by dhyatt on #webkit)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daniel Bates]

Not worth the memory use. Rollout as requested by David Hyatt.

[Daniel Bates]

Created attachment 56209 [details]
Patch

There were two conflict when rolling this out in files:

WebCore/rendering/SVGInlineFlowBox.h (conflict due to changes in http://trac.webkit.org/changeset/59589>).
WebCore/rendering/RenderBlockLineLayout.cpp (conflict due to changes in <http://trac.webkit.org/changeset/59588>).

[Dave Hyatt]

Comment on attachment 56209 [details]
Patch

r=me

[WebKit Review Bot]

Attachment 56209 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/rendering/InlineBox.h:145:  More than one command on the same line  [whitespace/newline] [4]
WebCore/rendering/InlineTextBox.h:99:  More than one command on the same line  [whitespace/newline] [4]
WebCore/rendering/InlineTextBox.cpp:738:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/InlineTextBox.cpp:911:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/InlineTextBox.cpp:930:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 5 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

Comment on attachment 56209 [details]
Patch

Clearing commit-queue flag. Will update change log to reflect revision we are rolling out and its corresponding bug and land manually.

[Daniel Bates]

Committed in change-set 59592 <http://trac.webkit.org/changeset/59592>.