Bug 39150 - Canvas's getContext() must return null when called with an invalid/unsupported parameter
: Canvas's getContext() must return null when called with an invalid/unsupporte...
Status: CLOSED FIXED
: WebKit
WebCore Misc.
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
: 35784
  Show dependency treegraph
 
Reported: 2010-05-14 23:22 PST by
Modified: 2010-05-18 13:52 PST (History)


Attachments
Proposed patch (5.34 KB, patch)
2010-05-14 23:24 PST, Andreas Kling
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


------- Comment #1 From 2010-05-14 23:24:21 PST -------
Created an attachment (id=56142) [details]
Proposed patch
------- Comment #2 From 2010-05-15 12:15:15 PST -------
(From update of attachment 56142 [details])
LGTM, but please add the spec link to the ChangeLog
------- Comment #3 From 2010-05-15 17:59:21 PST -------
(From update of attachment 56142 [details])
Looks like the spec link is already in the WebCore ChangeLog.  Did you mean that it should be in the LayoutTests ChangeLog too?
------- Comment #4 From 2010-05-15 18:21:54 PST -------
I overlooked that, my bad. Having it both places makes sense though. Another option would be to link to it from the test itself.
------- Comment #5 From 2010-05-16 00:58:58 PST -------
(From update of attachment 56142 [details])
Clearing flags on attachment: 56142

Committed r59569: <http://trac.webkit.org/changeset/59569>
------- Comment #6 From 2010-05-16 00:59:04 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #7 From 2010-05-18 13:52:26 PST -------
Revision r59569 cherry-picked into qtwebkit-2.0 with commit 14cc1d210d6f2b951f74a5906640d0db4778e9b7