Bug 39142 - [chromium] Implement support for composited layers containing only an Image element
Summary: [chromium] Implement support for composited layers containing only an Image e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-14 16:16 PDT by Vangelis Kokkevis
Modified: 2010-05-15 13:04 PDT (History)
4 users (show)

See Also:


Attachments
Proposed patch (5.78 KB, patch)
2010-05-14 16:33 PDT, Vangelis Kokkevis
fishd: review+
fishd: commit-queue-
Details | Formatted Diff | Diff
Patch fixed. Added URL to bug in ChangeLog (5.84 KB, patch)
2010-05-14 16:57 PDT, Vangelis Kokkevis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vangelis Kokkevis 2010-05-14 16:16:39 PDT
Composited Layers that contain only an Image follow a special path that doesn't require allocating additional storage for keeping around the associated bitmap. That path hasn't been implemented in LayerChromium yet.
Comment 1 Vangelis Kokkevis 2010-05-14 16:33:38 PDT
Created attachment 56121 [details]
Proposed patch
Comment 2 Darin Fisher (:fishd, Google) 2010-05-14 16:51:23 PDT
Comment on attachment 56121 [details]
Proposed patch

WebCore/ChangeLog:6
 +          an Image element.
nit: please add a bug reference here.

R=me with that fixed.
Comment 3 Vangelis Kokkevis 2010-05-14 16:57:48 PDT
Created attachment 56124 [details]
Patch fixed.  Added URL to bug in ChangeLog
Comment 4 Vangelis Kokkevis 2010-05-14 16:59:06 PDT
Uploaded the fix but I'm afraid that I might have inadvertently overwrite the r+ bit..
Comment 5 WebKit Commit Bot 2010-05-15 13:03:58 PDT
Comment on attachment 56124 [details]
Patch fixed.  Added URL to bug in ChangeLog

Clearing flags on attachment: 56124

Committed r59550: <http://trac.webkit.org/changeset/59550>
Comment 6 WebKit Commit Bot 2010-05-15 13:04:04 PDT
All reviewed patches have been landed.  Closing bug.