Bug 39135 - Rename GenericWorkerTask.h to CrossThreadTask.h and move it to dom directory
Summary: Rename GenericWorkerTask.h to CrossThreadTask.h and move it to dom directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jian Li
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-14 14:01 PDT by Jian Li
Modified: 2010-05-20 11:00 PDT (History)
3 users (show)

See Also:

Attachments
Proposed Patch (55.07 KB, patch)
2010-05-14 14:03 PDT, Jian Li 		levin: review-
jianli: commit-queue-
Details | Formatted Diff | Diff
Proposed Patch (55.88 KB, patch)
2010-05-18 18:10 PDT, Jian Li 		levin: review+
jianli: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2010-05-14 14:01:57 PDT 
This is the second patch to reposition GenericWorkerTask so that it can be used by more components.
Comment 1 Jian Li 2010-05-14 14:03:46 PDT 
Created attachment 56108 [details]
Proposed Patch
Comment 2 David Levin 2010-05-14 14:49:42 PDT 
Comment on attachment 56108 [details]
Proposed Patch

It looks good to me except for the fact that WebCore/WebCore.xcodeproj/project.pbxproj isn't fixed up completely. For example, the files haven't been moved to the correct new directory.

I think I know how to fix this by hand (look for "children =" in that file), but in general this points out to me that the pbxproj file is tricky to edit by hand. I'd suggest that it would be better to open this file in xcode and delete the file and re-add it (if possible).
Comment 3 Alexey Proskuryakov 2010-05-14 19:43:31 PDT 
CrossThreadCopier is not something I'd expect to see in "GenericTask". Is that something you plan to change next?
Comment 4 Jian Li 2010-05-18 18:10:14 PDT 
Created attachment 56436 [details]
Proposed Patch

Fixed WebCore.xcodeproj/project.pbxproj. Also changed to rename to CrossThreadTask.
Comment 5 Jian Li 2010-05-20 11:00:02 PDT 
Committed as http://trac.webkit.org/changeset/59849.