Bug 39129 - Remove the ENABLE(WORKERS) guard from GenericWorkerTask.h and update the names in this file
Summary: Remove the ENABLE(WORKERS) guard from GenericWorkerTask.h and update the name...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jian Li
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-14 11:54 PDT by Jian Li
Modified: 2010-05-14 13:27 PDT (History)
2 users (show)

See Also:


Attachments
Proposed Patch (25.42 KB, patch)
2010-05-14 11:56 PDT, Jian Li
dimich: review+
jianli: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2010-05-14 11:54:35 PDT
We now have more code components that depend on GenericWorkerTask, not just limiting to workers. So we need to remove the ENABLE(WORKERS) guard and rename it.

This is the first issue to address this:
1) Remove the ENABLE(WORKERS) guard.
2) Rename GenericWorkerTask* to GenericTask* in GenericWorkerTask.h

A second issue will be created to rename the file and move it to other place.
Comment 1 Jian Li 2010-05-14 11:56:36 PDT
Created attachment 56091 [details]
Proposed Patch
Comment 2 WebKit Review Bot 2010-05-14 11:58:08 PDT
Attachment 56091 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/workers/GenericWorkerTask.h:31:  #ifndef header guard has wrong style, please use: GenericWorkerTask_h  [build/header_guard] [5]
WebCore/workers/GenericWorkerTask.h:44:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dmitry Titov 2010-05-14 12:04:20 PDT
Comment on attachment 56091 [details]
Proposed Patch

WebCore/ChangeLog:5
 +          Remove the ENABLE(WORKERS) guard from GenericWorkerTask.h and update the
Could you mention the actual rename of the classes instead of 'update' and also that the rename of the file will be another patch very soon?
Comment 4 Jian Li 2010-05-14 13:27:54 PDT
Fixed and committed as http://trac.webkit.org/changeset/59484.