RESOLVED FIXED 39129
Remove the ENABLE(WORKERS) guard from GenericWorkerTask.h and update the names in this file 
https://bugs.webkit.org/show_bug.cgi?id=39129
Summary Remove the ENABLE(WORKERS) guard from GenericWorkerTask.h and update the name...
Jian Li
Reported 2010-05-14 11:54:35 PDT
We now have more code components that depend on GenericWorkerTask, not just limiting to workers. So we need to remove the ENABLE(WORKERS) guard and rename it. This is the first issue to address this: 1) Remove the ENABLE(WORKERS) guard. 2) Rename GenericWorkerTask* to GenericTask* in GenericWorkerTask.h A second issue will be created to rename the file and move it to other place.
Attachments
Proposed Patch (25.42 KB, patch)
2010-05-14 11:56 PDT, Jian Li 		dimich: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2010-05-14 11:56:36 PDT
Created attachment 56091 [details] Proposed Patch
WebKit Review Bot
Comment 2 2010-05-14 11:58:08 PDT
Attachment 56091 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/workers/GenericWorkerTask.h:31: #ifndef header guard has wrong style, please use: GenericWorkerTask_h [build/header_guard] [5] WebCore/workers/GenericWorkerTask.h:44: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dmitry Titov
Comment 3 2010-05-14 12:04:20 PDT
Comment on attachment 56091 [details] Proposed Patch WebCore/ChangeLog:5 + Remove the ENABLE(WORKERS) guard from GenericWorkerTask.h and update the Could you mention the actual rename of the classes instead of 'update' and also that the rename of the file will be another patch very soon?
Jian Li
Comment 4 2010-05-14 13:27:54 PDT
Fixed and committed as http://trac.webkit.org/changeset/59484.
Note You need to log in before you can comment on or make changes to this bug.