We now have more code components that depend on GenericWorkerTask, not just limiting to workers. So we need to remove the ENABLE(WORKERS) guard and rename it. This is the first issue to address this: 1) Remove the ENABLE(WORKERS) guard. 2) Rename GenericWorkerTask* to GenericTask* in GenericWorkerTask.h A second issue will be created to rename the file and move it to other place.
Created attachment 56091 [details] Proposed Patch
Attachment 56091 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/workers/GenericWorkerTask.h:31: #ifndef header guard has wrong style, please use: GenericWorkerTask_h [build/header_guard] [5] WebCore/workers/GenericWorkerTask.h:44: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 56091 [details] Proposed Patch WebCore/ChangeLog:5 + Remove the ENABLE(WORKERS) guard from GenericWorkerTask.h and update the Could you mention the actual rename of the classes instead of 'update' and also that the rename of the file will be another patch very soon?
Fixed and committed as http://trac.webkit.org/changeset/59484.