Bug 39100 – Implement TypedArray BYTES_PER_ELEMENT

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kenneth Russell]

The constant value BYTES_PER_ELEMENT needs to be added to the various TypedArray interfaces.

[Kenneth Russell]

Created attachment 58308 [details]
Patch

From the ChangeLog:

Implemented BYTES_PER_ELEMENT on all ArrayBufferView subclasses. Required bug fixes to JSC bindings' custom constructors. Updated fast/canvas/webgl/array-unit-tests.html to verify. Ran all WebGL layout tests in Safari and Chromium.

[Kenneth Russell]

Note: the modifications to the JSC custom bindings came from looking at the autogenerated JSCSSValue.{cpp.h}, which has values like CSS_INHERIT attached to its prototype. From experimentation these are the minimal changes to the custom constructors which allow the BYTES_PER_ELEMENT lookup to succeed on the constructor functions (i.e., "Float32Array.BYTES_PER_ELEMENT") while also not perturbing the functionality in any way.

[Dimitri Glazkov (Google)]

Comment on attachment 58308 [details]
Patch

ok. Can we not make the constructors non-custom with the new overloading goodness that Yaar had built?

[Kenneth Russell]

(In reply to comment #3)
> (From update of attachment 58308 [details])
> ok. Can we not make the constructors non-custom with the new overloading goodness that Yaar had built?

It may be possible; I'll ask Yaar. I don't know how the IDL and code generator handle autogenerated constructors and/or overloaded constructors.

[Kenneth Russell]

Committed r60967: <http://trac.webkit.org/changeset/60967>