Bug 39090 - Don't send mail if the only change is to the in-rietveld flag.
: Don't send mail if the only change is to the in-rietveld flag.
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Tools / Tests
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To: Julie Parent
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-13 15:28 PDT by Julie Parent
Modified: 2010-05-14 15:55 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.35 KB, patch)
2010-05-13 15:34 PDT, Julie Parent
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julie Parent 2010-05-13 15:28:42 PDT
Only used by tools, don't want to spam the world.
Comment 1 Julie Parent 2010-05-13 15:34:10 PDT
Created attachment 56029 [details]
Patch
Comment 2 Adam Barth 2010-05-13 17:04:35 PDT
Comment on attachment 56029 [details]
Patch

Crazy.  Looks hacky, but the whole file looks hacky...  I'll give others a chance to look, but it seems reasonable to me.
Comment 3 Tony Chang 2010-05-13 17:36:09 PDT
Can we do something similar for commit-queue?  Maybe just setting commit-queue? .  Normally I run webkit-patch upload and manually set the commit-queue flag because I forgot to add --request-commit.
Comment 4 Adam Barth 2010-05-13 19:37:14 PDT
That's an interesting idea.  I'd still like email for commit-queue+ though.
Comment 5 Tony Chang 2010-05-13 20:18:05 PDT
(In reply to comment #4)
> That's an interesting idea.  I'd still like email for commit-queue+ though.

I agree, I still want email for commit-queue+.
Comment 6 Julie Parent 2010-05-14 13:56:44 PDT
I've separated the commit-queue request into another bug: https://bugs.webkit.org/show_bug.cgi?id=39134
Comment 7 David Kilzer (:ddkilzer) 2010-05-14 15:43:37 PDT
Comment on attachment 56029 [details]
Patch

r=me
Comment 8 Julie Parent 2010-05-14 15:55:34 PDT
Committed: http://trac.webkit.org/changeset/59500