Bug 39090 - Don't send mail if the only change is to the in-rietveld flag.
: Don't send mail if the only change is to the in-rietveld flag.
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-05-13 15:28 PST by
Modified: 2010-05-14 15:55 PST (History)


Attachments
Patch (1.35 KB, patch)
2010-05-13 15:34 PST, Julie Parent
ddkilzer: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-05-13 15:28:42 PST
Only used by tools, don't want to spam the world.
------- Comment #1 From 2010-05-13 15:34:10 PST -------
Created an attachment (id=56029) [details]
Patch
------- Comment #2 From 2010-05-13 17:04:35 PST -------
(From update of attachment 56029 [details])
Crazy.  Looks hacky, but the whole file looks hacky...  I'll give others a chance to look, but it seems reasonable to me.
------- Comment #3 From 2010-05-13 17:36:09 PST -------
Can we do something similar for commit-queue?  Maybe just setting commit-queue? .  Normally I run webkit-patch upload and manually set the commit-queue flag because I forgot to add --request-commit.
------- Comment #4 From 2010-05-13 19:37:14 PST -------
That's an interesting idea.  I'd still like email for commit-queue+ though.
------- Comment #5 From 2010-05-13 20:18:05 PST -------
(In reply to comment #4)
> That's an interesting idea.  I'd still like email for commit-queue+ though.

I agree, I still want email for commit-queue+.
------- Comment #6 From 2010-05-14 13:56:44 PST -------
I've separated the commit-queue request into another bug: https://bugs.webkit.org/show_bug.cgi?id=39134
------- Comment #7 From 2010-05-14 15:43:37 PST -------
(From update of attachment 56029 [details])
r=me
------- Comment #8 From 2010-05-14 15:55:34 PST -------
Committed: http://trac.webkit.org/changeset/59500