Bug 39084 - More :visited link optimizations to reduce memory usage
Summary: More :visited link optimizations to reduce memory usage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P1 Critical
Assignee: Dave Hyatt
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-05-13 13:38 PDT by Dave Hyatt
Modified: 2010-05-14 10:01 PDT (History)
5 users (show)

See Also:


Attachments
Patch (15.20 KB, patch)
2010-05-13 13:39 PDT, Dave Hyatt
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-05-13 13:38:19 PDT
More :visited link optimizations to reduce memory usage
Comment 1 Dave Hyatt 2010-05-13 13:39:06 PDT
Created attachment 56015 [details]
Patch
Comment 2 Dave Hyatt 2010-05-13 13:39:44 PDT
<rdar://problem/7965202>
Comment 3 WebKit Review Bot 2010-05-13 13:42:52 PDT
Attachment 56015 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/css/CSSStyleSelector.cpp:1171:  One space before end of line comments  [whitespace/comments] [5]
WebCore/css/CSSStyleSelector.cpp:1470:  One space before end of line comments  [whitespace/comments] [5]
WebCore/css/CSSStyleSelector.cpp:2935:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/css/CSSStyleSelector.cpp:2934:  Missing space before ( in switch(  [whitespace/parens] [5]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Anders Carlsson 2010-05-13 14:47:30 PDT
Comment on attachment 56015 [details]
Patch

Looks good, r=me!
Comment 5 Dave Hyatt 2010-05-13 14:51:51 PDT
Fixed in r59386.
Comment 6 WebKit Review Bot 2010-05-13 15:55:49 PDT
http://trac.webkit.org/changeset/59387 might have broken Qt Windows 32-bit Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/59387
http://trac.webkit.org/changeset/59388
http://trac.webkit.org/changeset/59389
Comment 7 Shinichiro Hamaji 2010-05-14 09:56:02 PDT
Committed r59477: <http://trac.webkit.org/changeset/59477>
Comment 8 Shinichiro Hamaji 2010-05-14 10:01:45 PDT
(In reply to comment #7)
> Committed r59477: <http://trac.webkit.org/changeset/59477>

This is a small attempt to fix chromium's memory bot. Please check ChangeLog for detail.