Bug 39078 – Track state for whether a ResourceRequest is fetched via TLS/NPN

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Mike Belshe]

This is part of measuring effectiveness of SPDY; we plan to look at requests which are fetched using the TLS/NPN mechanism so that we can evaluate performance.

[Mike Belshe]

Created attachment 56001 [details]
initial patch

[Mike Belshe]

Created attachment 56002 [details]
patch fixing tabs in changelog

[Dimitri Glazkov (Google)]

Comment on attachment 56002 [details]
patch fixing tabs in changelog

ok.

[WebKit Commit Bot]

Comment on attachment 56002 [details]
patch fixing tabs in changelog

Rejecting patch 56002 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--force']" exit_code: 1
Last 500 characters of output:
network/chromium/ResourceResponse.h
Hunk #1 FAILED at 36.
Hunk #2 succeeded at 96 (offset 8 lines).
Hunk #3 FAILED at 104.
2 out of 3 hunks FAILED -- saving rejects to file WebCore/platform/network/chromium/ResourceResponse.h.rej
patching file WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/chromium/public/WebURLResponse.h
Hunk #1 succeeded at 126 (offset 3 lines).
patching file WebKit/chromium/src/WebURLResponse.cpp
Hunk #1 succeeded at 277 (offset 10 lines).

Full output: http://webkit-commit-queue.appspot.com/results/2296098

[Adam Barth]

Created attachment 56170 [details]
Manually merged

[Adam Barth]

This doesn't actually need to be reviewed again.  I just want the cr-linux EWS bot to run to make sure I did the merge right.  Also, this patch is missing a ChangeLog in the WebCore directory.

[Adam Barth]

Comment on attachment 56170 [details]
Manually merged

Looks like I did the merge ok.  Let's try to land.

[WebKit Commit Bot]

Comment on attachment 56170 [details]
Manually merged

Clearing flags on attachment: 56170

Committed r59574: <http://trac.webkit.org/changeset/59574>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/59574 might have broken Chromium Win Release

[Adam Barth]

(In reply to comment #10)
> http://trac.webkit.org/changeset/59574 might have broken Chromium Win Release

The compile error is something about trouble linking with WebGL.  Not sure how that's related to this patch.

[Adam Barth]

I'm rolling this out to see if that fixes cr-win.  I'm skeptical that it will.

[Adam Barth]

Comment on attachment 56170 [details]
Manually merged

Rollout didn't help.  Putting this back on the queue.  It's possible the bot needs to be kicked or the earlier change to DEPS is the problem.

[Eric Seidel (no email)]

I suspect the break may be related to earlier webgl renames from this week. I think this change just triggered a fuller-rebuil and exposed a error missed before due to build system failure.

There is a known issue with the win gyp build that it doesn't notice feature define changes.  We could have hit that.

Thanks Adam for the quick fix attempt. This change will automatically reland once the tree regreens

[Eric Seidel (no email)]

I think the real culprit was http://trac.webkit.org/changeset/59571

[Eric Seidel (no email)]

I believe the build system bug in question is https://bugs.webkit.org/show_bug.cgi?id=38926.

[Eric Seidel (no email)]

Comment on attachment 56170 [details]
Manually merged

Clearing flags on attachment: 56170

Committed r59579: <http://trac.webkit.org/changeset/59579>

[Eric Seidel (no email)]

All reviewed patches have been landed.  Closing bug.