Bug 39077 – Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Zhenyao Mo]

The three supported internal color formats RGBA4/RGB5_A1/RGB565 may not be supported by Desktop OpenGL.  We need to map them to general RGBA and RGB.

[Zhenyao Mo]

Created attachment 56021 [details]
patch

The same mapping is also added to command buffer implementation in Google Chrome.

[Kenneth Russell]

Comment on attachment 56021 [details]
patch

Should we do a similar reverse mapping for getRenderbufferParameter(RENDERBUFFER_INTERNAL_FORMAT) so we don't return enums that are undefined or illegal in the WebGL spec?

[Zhenyao Mo]

(In reply to comment #2)
> (From update of attachment 56021 [details])
> Should we do a similar reverse mapping for getRenderbufferParameter(RENDERBUFFER_INTERNAL_FORMAT) so we don't return enums that are undefined or illegal in the WebGL spec?

I just checked and realized the code for reverse mapping is already in place (see WebGLRenderingContext::getRenderbufferParameter and WebGLRenderingContext::renderbufferStorage).

It's added through this patch: https://bugs.webkit.org/show_bug.cgi?id=35611

[Kenneth Russell]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 56021 [details] [details])
> > Should we do a similar reverse mapping for getRenderbufferParameter(RENDERBUFFER_INTERNAL_FORMAT) so we don't return enums that are undefined or illegal in the WebGL spec?
> 
> I just checked and realized the code for reverse mapping is already in place (see WebGLRenderingContext::getRenderbufferParameter and WebGLRenderingContext::renderbufferStorage).
> 
> It's added through this patch: https://bugs.webkit.org/show_bug.cgi?id=35611

Right, I'd forgotten all about that.

Looks good to me.

[Eric Seidel (no email)]

Comment on attachment 56021 [details]
patch

Why so much  copy/paste code in the layout test?

[Zhenyao Mo]

Created attachment 56298 [details]
revised patch

Reduced the code duplication in the test (responding to Eric Seidel's comment).

[Dimitri Glazkov (Google)]

Comment on attachment 56298 [details]
revised patch

rs=me.

[WebKit Commit Bot]

Comment on attachment 56298 [details]
revised patch

Clearing flags on attachment: 56298

Committed r59888: <http://trac.webkit.org/changeset/59888>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.