RESOLVED FIXED Bug 39074
Web Inspector: Event Markers should be hidden in Resource's "Size" Graph 
https://bugs.webkit.org/show_bug.cgi?id=39074
Summary Web Inspector: Event Markers should be hidden in Resource's "Size" Graph
Joseph Pecoraro
Reported 2010-05-13 10:00:49 PDT
Event markers make no sense in the Size graph. Patch to follow.
Attachments
[PATCH] Add Show/Hide functionality to Event Dividers in Timeline Graph (5.15 KB, patch)
2010-05-13 10:06 PDT, Joseph Pecoraro 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2010-05-13 10:06:45 PDT
Created attachment 55992 [details] [PATCH] Add Show/Hide functionality to Event Dividers in Timeline Graph These were already designed very nicely to be contained in a <div>. Great forethought!
Pavel Feldman
Comment 2 2010-05-13 10:10:48 PDT
Comment on attachment 55992 [details] [PATCH] Add Show/Hide functionality to Event Dividers in Timeline Graph r+ with nits. WebCore/inspector/front-end/TimelineGrid.js:153 + this._eventDividersElement.style.display = "none"; Timothy likes add/removeStyleClass("hidden"). You don't need dedicated methods for it too...
Joseph Pecoraro
Comment 3 2010-05-13 10:28:36 PDT
> WebCore/inspector/front-end/TimelineGrid.js:153 > > + this._eventDividersElement.style.display = "none"; > Timothy likes add/removeStyleClass("hidden"). Done. Committed r59372 M WebCore/ChangeLog M WebCore/inspector/front-end/TimelineGrid.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/AbstractTimelinePanel.js r59372 = 6c5ad77bbc072a3a315726f172304fd7cde898d4 (refs/remotes/trunk) http://trac.webkit.org/changeset/59372
Note You need to log in before you can comment on or make changes to this bug.