Bug 39067 - Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
Summary: Disable compositing/iframes tests on the commit-queue as a workaround for bu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 38912
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-13 07:26 PDT by Eric Seidel (no email)
Modified: 2010-05-22 10:59 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.72 KB, patch)
2010-05-13 07:32 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (5.70 KB, patch)
2010-05-13 11:08 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (2.40 KB, patch)
2010-05-13 12:04 PDT, Eric Seidel (no email)
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-05-13 07:26:32 PDT
Disable compositing/iframes tests on the commit-queue as a workaround for  bug 38912
Comment 1 Eric Seidel (no email) 2010-05-13 07:32:32 PDT
Created attachment 55975 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-05-13 07:32:57 PDT
This ugly hack just needs a rubber-stamp.
Comment 3 Eric Seidel (no email) 2010-05-13 07:36:01 PDT
Hmmm... We're reviewerless in #webkit atm.  Going to check this in w/o review but I would be happy to field any comments when folks wake!
Comment 4 Eric Seidel (no email) 2010-05-13 07:40:26 PDT
Committed r59364: <http://trac.webkit.org/changeset/59364>
Comment 5 Daniel Bates 2010-05-13 07:48:38 PDT
Comment on attachment 55975 [details]
Patch

Sucks that we have to have a hack, but it's just a holdover (hopefully) until bug 38912.
Comment 6 Eric Seidel (no email) 2010-05-13 11:08:36 PDT
Created attachment 56000 [details]
Patch
Comment 7 Eric Seidel (no email) 2010-05-13 11:33:53 PDT
Committed r59375: <http://trac.webkit.org/changeset/59375>
Comment 8 Eric Seidel (no email) 2010-05-13 12:04:12 PDT
Created attachment 56005 [details]
Patch
Comment 9 Eric Seidel (no email) 2010-05-13 12:10:11 PDT
Committed r59379: <http://trac.webkit.org/changeset/59379>
Comment 10 Eric Seidel (no email) 2010-05-22 10:54:03 PDT
compositing/iframes/composited-parent-iframe.html
compositing/iframes/connect-compositing-iframe2.html
compositing/iframes/connect-compositing-iframe3.html
compositing/iframes/connect-compositing-iframe-delayed.html
compositing/iframes/connect-compositing-iframe.html
compositing/iframes/enter-compositing-iframe.html
compositing/iframes/scrolling-iframe.html
compositing/tiling/huge-layer-add-remove-child.html
compositing/tiling/huge-layer-resize.html
compositing/tiling/huge-layer-with-layer-children-resize.html
compositing/tiling/huge-layer-with-layer-children.html
compositing/tiling/huge-layer.html

is the full list of compoisting tests which fails on Leopard with compositing disabled.
Comment 11 Eric Seidel (no email) 2010-05-22 10:56:00 PDT
Committed r60006: <http://trac.webkit.org/changeset/60006>
Comment 12 Eric Seidel (no email) 2010-05-22 10:59:58 PDT
Committed r60007: <http://trac.webkit.org/changeset/60007>