Bug 39057 - Web Inspector: A disabled style property cannot be deleted
Summary: Web Inspector: A disabled style property cannot be deleted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-13 05:23 PDT by Alexander Pavlov (apavlov)
Modified: 2010-05-13 12:24 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed fix. (7.67 KB, patch)
2010-05-13 09:57 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
[PATCH] Comments addressed. (11.29 KB, patch)
2010-05-13 10:49 PDT, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2010-05-13 05:23:19 PDT 
1. In some CSS rule (with 2 or more properties) in the Styles sidebar pane, disable a property
2. Delete the disabled property by clearing its edit-box, as usual
3. Disable another property in the same rule

The property deleted in step 2 re-appears in a disabled state.
The requirement of 2 or more properties in step 1 is not mandatory, it's there merely to manifest the issue in an easy way.
Comment 1 Pavel Feldman 2010-05-13 09:57:45 PDT 
Created attachment 55991 [details]
[PATCH] Proposed fix.
Comment 2 Yury Semikhatsky 2010-05-13 10:26:48 PDT 
Comment on attachment 55991 [details]
[PATCH] Proposed fix.

LayoutTests/inspector/styles-disable-then-delete.html:37
 +      testController.runAfterPendingDispatches(frontend_deleteContainerStyle.bind(this, testController));
Can you pass __result as a parameter as well instead of creating a global __result?
Also it's not clear what 'bind(this,' means in this context, should it be .bind(null, ?
Comment 3 Pavel Feldman 2010-05-13 10:49:15 PDT 
Created attachment 55996 [details]
[PATCH] Comments addressed.
Comment 4 Pavel Feldman 2010-05-13 12:24:27 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	C	LayoutTests/inspector/styles-disable-then-enable.html => LayoutTests/inspector/styles-disable-then-delete.html
	M	LayoutTests/ChangeLog
	M	LayoutTests/inspector/elements-tests.js
	M	LayoutTests/inspector/styles-disable-inherited.html
	A	LayoutTests/inspector/styles-disable-then-delete-expected.txt
	M	LayoutTests/inspector/styles-disable-then-enable.html
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorDOMAgent.cpp
	M	WebCore/inspector/front-end/TestController.js
Committed r59381