Bug 39056 – fast/forms/implicit-submission.html is flakey

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Takeshi Yoshino]

I'd like to update test_expectations.txt for fast/forms/implicit-submission.html on Chromium

http://code.google.com/p/chromium/issues/detail?id=43890

[Takeshi Yoshino]

Created attachment 55963 [details]
Proposed patch - revision 0

[Shinichiro Hamaji]

Comment on attachment 55963 [details]
Proposed patch - revision 0

Rubber stamping

[Takeshi Yoshino]

Thank you for quick work.

[WebKit Commit Bot]

Comment on attachment 55963 [details]
Proposed patch - revision 0

Rejecting patch 55963 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Shinichiro Hamaji', u'--force']" exit_code: 1
Last 500 characters of output:
eded at 1 with fuzz 3.
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: platform/chromium/test_expectations.txt
|===================================================================
|--- platform/chromium/test_expectations.txt	(revision 59170)
|+++ platform/chromium/test_expectations.txt	(working copy)
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored

Full output: http://webkit-commit-queue.appspot.com/results/2293130

[Adam Barth]

Looks like this was landed already.

Note: the patch was incorrectly based in LayoutTests instead of the root.  Please generate patches with webkit-patch or with svn-create-patch to make sure they're correctly based.

[Dimitri Glazkov (Google)]

:(

I didn't expect this test to be flakey. I wrote it, btw. Hijacking this bug to fix.

[Takeshi Yoshino]

(In reply to comment #5)
> Looks like this was landed already.
> Note: the patch was incorrectly based in LayoutTests instead of the root.  Please generate patches with webkit-patch or with svn-create-patch to make sure they're correctly based.

Sorry for that. I'll do so from the next time. Thank you.

[Eric Seidel (no email)]

Comment on attachment 55963 [details]
Proposed patch - revision 0

Obsoleting patch since it was landed.

[Dimitri Glazkov (Google)]

Created attachment 136087 [details]
Patch

[Dimitri Glazkov (Google)]

Created attachment 136091 [details]
Make it work without DRT.

[Hajime Morrita]

Comment on attachment 136091 [details]
Make it work without DRT.

View in context: https://bugs.webkit.org/attachment.cgi?id=136091&action=review

> LayoutTests/fast/forms/implicit-submission.html:134
> +        arena.appendChild(a);

You are using global-variable-by-id!

[WebKit Review Bot]

Comment on attachment 136091 [details]
Make it work without DRT.

Clearing flags on attachment: 136091

Committed r113808: <http://trac.webkit.org/changeset/113808>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.