I'd like to update test_expectations.txt for fast/forms/implicit-submission.html on Chromium http://code.google.com/p/chromium/issues/detail?id=43890
Created attachment 55963 [details] Proposed patch - revision 0
Comment on attachment 55963 [details] Proposed patch - revision 0 Rubber stamping
Thank you for quick work.
Comment on attachment 55963 [details] Proposed patch - revision 0 Rejecting patch 55963 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Shinichiro Hamaji', u'--force']" exit_code: 1 Last 500 characters of output: eded at 1 with fuzz 3. can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: platform/chromium/test_expectations.txt |=================================================================== |--- platform/chromium/test_expectations.txt (revision 59170) |+++ platform/chromium/test_expectations.txt (working copy) -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored Full output: http://webkit-commit-queue.appspot.com/results/2293130
Looks like this was landed already. Note: the patch was incorrectly based in LayoutTests instead of the root. Please generate patches with webkit-patch or with svn-create-patch to make sure they're correctly based.
:( I didn't expect this test to be flakey. I wrote it, btw. Hijacking this bug to fix.
(In reply to comment #5) > Looks like this was landed already. > Note: the patch was incorrectly based in LayoutTests instead of the root. Please generate patches with webkit-patch or with svn-create-patch to make sure they're correctly based. Sorry for that. I'll do so from the next time. Thank you.
Comment on attachment 55963 [details] Proposed patch - revision 0 Obsoleting patch since it was landed.
Created attachment 136087 [details] Patch
Created attachment 136091 [details] Make it work without DRT.
Comment on attachment 136091 [details] Make it work without DRT. View in context: https://bugs.webkit.org/attachment.cgi?id=136091&action=review > LayoutTests/fast/forms/implicit-submission.html:134 > + arena.appendChild(a); You are using global-variable-by-id!
Comment on attachment 136091 [details] Make it work without DRT. Clearing flags on attachment: 136091 Committed r113808: <http://trac.webkit.org/changeset/113808>
All reviewed patches have been landed. Closing bug.