Bug 39056 - fast/forms/implicit-submission.html is flakey
: fast/forms/implicit-submission.html is flakey
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: PC Linux
: P2 Normal
Assigned To:
:
:
: 9756
: 39021
  Show dependency treegraph
 
Reported: 2010-05-13 05:07 PST by
Modified: 2012-04-10 19:07 PST (History)


Attachments
Proposed patch - revision 0 (1.15 KB, patch)
2010-05-13 05:09 PST, Takeshi Yoshino
no flags Review Patch | Details | Formatted Diff | Diff
Patch (4.88 KB, patch)
2012-04-06 16:13 PST, Dimitri Glazkov (Google)
no flags Review Patch | Details | Formatted Diff | Diff
Make it work without DRT. (4.95 KB, patch)
2012-04-06 16:16 PST, Dimitri Glazkov (Google)
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-05-13 05:07:21 PST
I'd like to update test_expectations.txt for fast/forms/implicit-submission.html on Chromium

http://code.google.com/p/chromium/issues/detail?id=43890
------- Comment #1 From 2010-05-13 05:09:20 PST -------
Created an attachment (id=55963) [details]
Proposed patch - revision 0
------- Comment #2 From 2010-05-13 05:10:48 PST -------
(From update of attachment 55963 [details])
Rubber stamping
------- Comment #3 From 2010-05-13 05:20:27 PST -------
Thank you for quick work.
------- Comment #4 From 2010-05-15 17:02:05 PST -------
(From update of attachment 55963 [details])
Rejecting patch 55963 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Shinichiro Hamaji', u'--force']" exit_code: 1
Last 500 characters of output:
eded at 1 with fuzz 3.
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: platform/chromium/test_expectations.txt
|===================================================================
|--- platform/chromium/test_expectations.txt    (revision 59170)
|+++ platform/chromium/test_expectations.txt    (working copy)
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored

Full output: http://webkit-commit-queue.appspot.com/results/2293130
------- Comment #5 From 2010-05-15 17:46:44 PST -------
Looks like this was landed already.

Note: the patch was incorrectly based in LayoutTests instead of the root.  Please generate patches with webkit-patch or with svn-create-patch to make sure they're correctly based.
------- Comment #6 From 2010-05-15 19:57:53 PST -------
:(

I didn't expect this test to be flakey. I wrote it, btw. Hijacking this bug to fix.
------- Comment #7 From 2010-05-16 23:36:09 PST -------
(In reply to comment #5)
> Looks like this was landed already.
> Note: the patch was incorrectly based in LayoutTests instead of the root.  Please generate patches with webkit-patch or with svn-create-patch to make sure they're correctly based.

Sorry for that. I'll do so from the next time. Thank you.
------- Comment #8 From 2010-05-17 00:48:50 PST -------
(From update of attachment 55963 [details])
Obsoleting patch since it was landed.
------- Comment #9 From 2012-04-06 16:13:13 PST -------
Created an attachment (id=136087) [details]
Patch
------- Comment #10 From 2012-04-06 16:16:42 PST -------
Created an attachment (id=136091) [details]
Make it work without DRT.
------- Comment #11 From 2012-04-10 18:12:39 PST -------
(From update of attachment 136091 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=136091&action=review

> LayoutTests/fast/forms/implicit-submission.html:134
> +        arena.appendChild(a);

You are using global-variable-by-id!
------- Comment #12 From 2012-04-10 19:07:49 PST -------
(From update of attachment 136091 [details])
Clearing flags on attachment: 136091

Committed r113808: <http://trac.webkit.org/changeset/113808>
------- Comment #13 From 2012-04-10 19:07:54 PST -------
All reviewed patches have been landed.  Closing bug.