Bug 39050 – Move transient glyph overflow and fallback font data from a global to the stack

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

The way the lifetime of fallback font vectors and glyph overflow structures associated with text boxes is managed during layout is quite fragile. The data are inserted into a global map by one method, then consumed and removed by other methods. Instead, the map can be kept on the stack for the duration of line layout. Patch forthcoming.

Created attachment 55950 [details]
Use a stack-based GlyphOverflowAndFallbackFontsMap

[Darin Adler]

Comment on attachment 55950 [details]
Use a stack-based GlyphOverflowAndFallbackFontsMap

> +                                             int& maxAscent, int& maxDescent, bool strictMode, GlyphOverflowAndFallbackFontsMap& glyphOverflowAndFallbackFontsMap)

Can we give this argument a shorter less-precise name, perhaps overflowMap or fallbackMap or extrasMap or exceptionsMap?

[Adam Barth]

Attachment 55950 [details] was posted by a committer and has review+, assigning to Dan Bernstein for commit.

Fixed in <http://trac.webkit.org/projects/webkit/changeset/59588>.

[WebKit Review Bot]

http://trac.webkit.org/changeset/59588 might have broken Qt Windows 32-bit Release

[Tony Chang]

This is causing 2 tests to fail on the mac bots and the chromium bots:
svg/custom/pointer-events-text.svg
svg/custom/use-events-crash.svg

(In reply to comment #6)
> This is causing 2 tests to fail on the mac bots and the chromium bots:
> svg/custom/pointer-events-text.svg
> svg/custom/use-events-crash.svg

I’ll fix that.

in r59589

[Adam Barth]

(In reply to comment #5)
> http://trac.webkit.org/changeset/59588 might have broken Qt Windows 32-bit Release

Looks like a compile failure due to an ICE:


..\..\..\WebCore\dom\Document.cpp: In member function 'void WebCore::Document::addElementById(const WebCore::AtomicString&, WebCore::Element*)':
..\..\..\WebCore\dom\Document.cpp:1074:6: internal compiler error: Segmentation fault