Bug 39049 - [chromium] disable DRT in chromium again
Summary: [chromium] disable DRT in chromium again
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-12 23:08 PDT by Tony Chang
Modified: 2010-05-12 23:20 PDT (History)
1 user (show)

See Also:


Attachments
Patch (9.96 KB, patch)
2010-05-12 23:08 PDT, Tony Chang
tkent: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-05-12 23:08:29 PDT
[chromium] disable DRT in chromium again
Comment 1 Tony Chang 2010-05-12 23:08:53 PDT
Created attachment 55948 [details]
Patch
Comment 2 Tony Chang 2010-05-12 23:10:59 PDT
Darin pointed out to me that we don't need to include features.gypi in webkit_support.gyp anymore.  So we don't need to have both webkit_support.gyp and webkit_support_in_chromium.gyp.  Here's the 3 sided path to having only webkit_support.gyp:

1) This patch to disable DRT building in chromium.
2) Roll DEPS into chromium.
3) Fix up chromium gyp files to use webkit_support.gyp and delete webkit_support_in_chromium.gyp
4) Re-enable DRT building in chromium.
Comment 3 Kent Tamura 2010-05-12 23:15:39 PDT
Comment on attachment 55948 [details]
Patch

OK
Comment 4 Tony Chang 2010-05-12 23:20:23 PDT
Committed r59346: <http://trac.webkit.org/changeset/59346>