WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
39043
Don't include RetainPtr.h unless PLATFORM(CF) is set
https://bugs.webkit.org/show_bug.cgi?id=39043
Summary
Don't include RetainPtr.h unless PLATFORM(CF) is set
Young Han Lee
Reported
2010-05-12 21:37:20 PDT
The RetainPtr is only used for CF platform in this class.
Attachments
patch
(1.13 KB, patch)
2010-05-12 21:49 PDT
,
Young Han Lee
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Young Han Lee
Comment 1
2010-05-12 21:49:05 PDT
Created
attachment 55941
[details]
patch
Darin Adler
Comment 2
2010-05-12 23:07:52 PDT
Comment on
attachment 55941
[details]
patch
> #include <errno.h> > #include <stdio.h> > +#if PLATFORM(CF) > #include <wtf/RetainPtr.h> > +#endif > #include <wtf/Threading.h> > #include <wtf/Vector.h> > #include <wtf/text/CString.h>
Includes inside #if go in their own paragraph, not sorted in the middle of the main include paragraph. We also normally put #if in headers so we don't have to make includes everywhere conditional. For example, see the #if ENABLE(SVG) in SVGElement.h. Despite those minor problems it seems OK to land this as-is.
WebKit Commit Bot
Comment 3
2010-05-14 12:49:45 PDT
Comment on
attachment 55941
[details]
patch Clearing flags on attachment: 55941 Committed
r59482
: <
http://trac.webkit.org/changeset/59482
>
WebKit Commit Bot
Comment 4
2010-05-14 12:49:50 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug