Bug 39043 - Don't include RetainPtr.h unless PLATFORM(CF) is set
Summary: Don't include RetainPtr.h unless PLATFORM(CF) is set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-12 21:37 PDT by Young Han Lee
Modified: 2010-05-14 12:49 PDT (History)
2 users (show)

See Also:


Attachments
patch (1.13 KB, patch)
2010-05-12 21:49 PDT, Young Han Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Young Han Lee 2010-05-12 21:37:20 PDT
The RetainPtr is only used for CF platform in this class.
Comment 1 Young Han Lee 2010-05-12 21:49:05 PDT
Created attachment 55941 [details]
patch
Comment 2 Darin Adler 2010-05-12 23:07:52 PDT
Comment on attachment 55941 [details]
patch

>  #include <errno.h>
>  #include <stdio.h>
> +#if PLATFORM(CF)
>  #include <wtf/RetainPtr.h>
> +#endif
>  #include <wtf/Threading.h>
>  #include <wtf/Vector.h>
>  #include <wtf/text/CString.h>

Includes inside #if go in their own paragraph, not sorted in the middle of the main include paragraph.

We also normally put #if in headers so we don't have to make includes everywhere conditional. For example, see the #if ENABLE(SVG) in SVGElement.h. Despite those minor problems it seems OK to land this as-is.
Comment 3 WebKit Commit Bot 2010-05-14 12:49:45 PDT
Comment on attachment 55941 [details]
patch

Clearing flags on attachment: 55941

Committed r59482: <http://trac.webkit.org/changeset/59482>
Comment 4 WebKit Commit Bot 2010-05-14 12:49:50 PDT
All reviewed patches have been landed.  Closing bug.