Bug 39039 - Provide support for separate bytecode/JIT code translations for call/construct usage
Summary: Provide support for separate bytecode/JIT code translations for call/construc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-12 19:49 PDT by Gavin Barraclough
Modified: 2010-05-12 21:02 PDT (History)
1 user (show)

See Also:


Attachments
The patch (72.84 KB, patch)
2010-05-12 19:58 PDT, Gavin Barraclough
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2010-05-12 19:49:56 PDT
This will allow us to produce code generated specifically for use as a constructor, not for general function use.
Comment 1 Gavin Barraclough 2010-05-12 19:58:29 PDT
Created attachment 55929 [details]
The patch

No performance impact.
Comment 2 WebKit Review Bot 2010-05-12 20:04:54 PDT
Attachment 55929 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
JavaScriptCore/jit/JITStubs.h:407:  cti_vm_lazyLinkConstruct is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2010-05-12 21:02:14 PDT
Transmitting file data ......................
Committed revision 59339.