Bug 39036 – Alias WebGLArray type names to TypedArray type names

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kenneth Russell]

The WebGL specification is changing from the WebGL<T>Array type names to using the names in the separate TypedArray spec. Because this is a reasonably large change for developers (including ourselves) to adapt to, we want to give them a grace period during which both type names work. The current nightly builds of Firefox, for example, support both naming conventions.

To address this we aim to provide new attributes on the DOMWindow object which follow the TypedArray spec's naming convention. Under the hood they will actually instantiate WebGL<T>Array C++ objects. A subsequent patch will rename the implementing classes to use the TypedArray naming convention. In the near future the aliases to the old WebGL<T>Array constructor functions will be deleted.

[Kenneth Russell]

Created attachment 55920 [details]
Patch

From the ChangeLog:

Exposed the existing WebGL<T>Array constructor functions on the DOMWindow under the naming convention in the TypedArray spec. The implementations will be renamed in a subsequent bug, and the aliases to the WebGL<T>Array type names eventually removed. Ran all WebGL layout tests in Safari and Chromium.

[Dimitri Glazkov (Google)]

Comment on attachment 55920 [details]
Patch

I wanted to make you change code generator to auto-generate these, but since they're temporary, ok :)

[Kenneth Russell]

Committed r59376: <http://trac.webkit.org/changeset/59376>

[WebKit Review Bot]

http://trac.webkit.org/changeset/59376 might have broken SnowLeopard Intel Release (Tests)

[Kenneth Russell]

Reopening because initial patch broke tests and was rolled out.

[Kenneth Russell]

Created attachment 56017 [details]
Revised patch

Revised patch including updates to global prototype and constructor tests.

[Dimitri Glazkov (Google)]

Comment on attachment 56017 [details]
Revised patch

r=me again.

[Kenneth Russell]

Committed r59388: <http://trac.webkit.org/changeset/59388>

[WebKit Review Bot]

http://trac.webkit.org/changeset/59388 might have broken Qt Windows 32-bit Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/59387
http://trac.webkit.org/changeset/59388
http://trac.webkit.org/changeset/59389