RESOLVED FIXED 39028
Make InlineBox use a frameRect for dimensions 
https://bugs.webkit.org/show_bug.cgi?id=39028
Summary Make InlineBox use a frameRect for dimensions
Dave Hyatt
Reported 2010-05-12 14:44:20 PDT
Make InlineBox use a frameRect for dimensions
Attachments
Patch (82.13 KB, patch)
2010-05-12 14:47 PDT, Dave Hyatt 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-05-12 14:47:26 PDT
Created attachment 55905 [details] Patch
WebKit Review Bot
Comment 2 2010-05-12 14:50:31 PDT
Attachment 55905 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/rendering/InlineTextBox.h:111: More than one command on the same line [whitespace/newline] [4] WebCore/rendering/InlineTextBox.cpp:738: One space before end of line comments [whitespace/comments] [5] WebCore/rendering/InlineTextBox.cpp:911: One space before end of line comments [whitespace/comments] [5] Total errors found: 3 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2010-05-12 14:55:12 PDT
Ignore the layout test results when reviewing. They shouldn't be included.
Sam Weinig
Comment 4 2010-05-12 15:04:46 PDT
Comment on attachment 55905 [details] Patch r=me
Dave Hyatt
Comment 5 2010-05-12 15:08:02 PDT
Landed in r59274.
mitz
Comment 6 2010-05-12 15:20:24 PDT
Is this a measurable memory regression?
Note You need to log in before you can comment on or make changes to this bug.