Bug 39028 - Make InlineBox use a frameRect for dimensions
Summary: Make InlineBox use a frameRect for dimensions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-12 14:44 PDT by Dave Hyatt
Modified: 2010-05-12 15:20 PDT (History)
2 users (show)

See Also:

Attachments
Patch (82.13 KB, patch)
2010-05-12 14:47 PDT, Dave Hyatt 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-05-12 14:44:20 PDT 
Make InlineBox use a frameRect for dimensions
Comment 1 Dave Hyatt 2010-05-12 14:47:26 PDT 
Created attachment 55905 [details]
Patch
Comment 2 WebKit Review Bot 2010-05-12 14:50:31 PDT 
Attachment 55905 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/rendering/InlineTextBox.h:111:  More than one command on the same line  [whitespace/newline] [4]
WebCore/rendering/InlineTextBox.cpp:738:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/InlineTextBox.cpp:911:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 3 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2010-05-12 14:55:12 PDT 
Ignore the layout test results when reviewing.  They shouldn't be included.
Comment 4 Sam Weinig 2010-05-12 15:04:46 PDT 
Comment on attachment 55905 [details]
Patch

r=me
Comment 5 Dave Hyatt 2010-05-12 15:08:02 PDT 
Landed in r59274.
Comment 6 mitz 2010-05-12 15:20:24 PDT 
Is this a measurable memory regression?