Bug 39024 - Hide in-rietveld flag for attachments
Summary: Hide in-rietveld flag for attachments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Julie Parent
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-12 13:50 PDT by Julie Parent
Modified: 2010-05-12 14:34 PDT (History)
0 users

See Also:


Attachments
Hides the in-rietveld flag from the UI. (14.54 KB, patch)
2010-05-12 14:14 PDT, Julie Parent
ojan: review-
Details | Formatted Diff | Diff
Once more, with correct diff'ing (used svn cp correctly this time) (15.33 KB, patch)
2010-05-12 14:23 PDT, Julie Parent
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julie Parent 2010-05-12 13:50:47 PDT
This is used by tooling only, and shouldn't clutter the UI.
Comment 1 Julie Parent 2010-05-12 14:14:01 PDT
Created attachment 55896 [details]
Hides the in-rietveld flag from the UI.
Comment 2 Ojan Vafai 2010-05-12 14:22:43 PDT
Comment on attachment 55896 [details]
Hides the in-rietveld flag from the UI.

Julie and I discussed in person. She's uploading a new patch with the cp'ed file properly svn cp'ed.
Comment 3 Julie Parent 2010-05-12 14:23:37 PDT
Created attachment 55900 [details]
Once more, with correct diff'ing (used svn cp correctly this time)
Comment 4 Ojan Vafai 2010-05-12 14:31:17 PDT
Comment on attachment 55900 [details]
Once more, with correct diff'ing (used svn cp correctly this time)

Ugh. This can't commit-queue since I'm not in committers.py as a reviewer yet.
Comment 5 Julie Parent 2010-05-12 14:34:48 PDT
Committed as http://trac.webkit.org/changeset/59271.