http://code.google.com/p/chromium/issues/detail?id=42981 Note that the functionality is not broken, just the state of the check. This affects all chromium platforms.
Created attachment 55899 [details] try1
Is "data" here some struct? Maybe it'd make more sense to just memset it to zero when it's created?
yes, data is a struct. Memsetting doesn't seem like it would produce the most intuitive code.
Comment on attachment 55899 [details] try1 I think we should either introduce default constructor or memset the struct instance in order to avoid future mistake when we add new members.
Created attachment 56007 [details] do initing in default constructor
Attachment 56007 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2253037
Created attachment 56009 [details] syntax
Comment on attachment 56009 [details] syntax We usually put constructors at the top of the declaration. It's a bit odd to have a struct with a constructor, but I think we do that in other places too.
all the structs I checked in WebKit/chromium/public/ (WebRect, WebSize, WebFindOptions, WebScriptSource, etc.) put the constructor(s) after the data members.
Comment on attachment 56009 [details] syntax Ok. We might want to change all of those in the future. Thanks for being consistent with nearby existing code.
Comment on attachment 56009 [details] syntax Clearing flags on attachment: 56009 Committed r59529: <http://trac.webkit.org/changeset/59529>
All reviewed patches have been landed. Closing bug.