Bug 39015 - [chromium] Avoid crash when msttcorefonts aren't provided
Summary: [chromium] Avoid crash when msttcorefonts aren't provided
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-12 12:45 PDT by Adam Langley
Modified: 2010-05-24 14:25 PDT (History)
1 user (show)

See Also:


Attachments
patch (1.30 KB, patch)
2010-05-12 12:48 PDT, Adam Langley
no flags Details | Formatted Diff | Diff
patch (1.31 KB, patch)
2010-05-12 12:53 PDT, Adam Langley
no flags Details | Formatted Diff | Diff
patch (2.96 KB, patch)
2010-05-19 16:07 PDT, Adam Langley
levin: review+
agl: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Adam Langley 2010-05-12 12:48:13 PDT
Created attachment 55888 [details]
patch
Comment 2 WebKit Review Bot 2010-05-12 12:51:05 PDT
Attachment 55888 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/graphics/chromium/FontCacheLinux.cpp:133:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Langley 2010-05-12 12:53:02 PDT
Created attachment 55889 [details]
patch
Comment 4 Evan Martin 2010-05-13 00:12:15 PDT
LGTM.  Might want to note what you're actually changing in the changelog.  I'm not sure why this code used to work...
Comment 5 David Levin 2010-05-19 11:53:53 PDT
Why is there no layout test?
Comment 6 Adam Langley 2010-05-19 12:03:53 PDT
(In reply to comment #5)
> Why is there no layout test?

Our tests run with these fonts available (and they're critical to hundreds of other tests).
Comment 7 David Levin 2010-05-19 15:16:20 PDT
One last attempt, would this trigger the code path?
  <html> 
  <body> 
  <span style="font-family: -webkit-family-will-not-be-found;">Foo</span> 
  </body> 
  </html>
Comment 8 Adam Langley 2010-05-19 15:27:16 PDT
(In reply to comment #7)
> One last attempt, would this trigger the code path?
>   <html> 
>   <body> 
>   <span style="font-family: -webkit-family-will-not-be-found;">Foo</span> 
>   </body> 
>   </html>

Sadly yes. But the thought of burning hours away on another layout test has just sapped my will to live so I'm going to head home instead.
Comment 9 Adam Langley 2010-05-19 16:06:48 PDT
> Sadly yes. But the thought of burning hours away on another layout test has just sapped my will to live so I'm going to head home instead.

That was shitty of me to take WebKit frustrations out on you. Thanks for finding the test case.
Comment 10 Adam Langley 2010-05-19 16:07:11 PDT
Created attachment 56529 [details]
patch
Comment 11 Adam Langley 2010-05-24 14:25:39 PDT
r59835