Bug 39006 - [Qt] Link error in debug mode without debug_and_release config
Summary: [Qt] Link error in debug mode without debug_and_release config
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Windows XP
: P3 Normal
Assignee: QtWebKit Unassigned
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-05-12 11:05 PDT by Csaba Osztrogonác
Modified: 2010-05-12 14:10 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.20 KB, patch)
2010-05-12 11:11 PDT, Csaba Osztrogonác
kenneth: review+
ossy: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-05-12 11:05:42 PDT
I experimented with removing default debug_and_release config from win32-g++/qmake.conf . 
Now qmake runs twice unnecessarly and generate makefiles for release and debug mode too.

After removing debug build broke because of a little bug. Fix is coming soon.
Comment 1 Csaba Osztrogonác 2010-05-12 11:11:00 PDT
Created attachment 55872 [details]
Patch
Comment 2 Csaba Osztrogonác 2010-05-12 11:18:25 PDT
-                CONFIG(debug, debug|release):build_pass: QTWEBKITLIBNAME = $${QTWEBKITLIBNAME}d
+                CONFIG(debug, debug|release):QTWEBKITLIBNAME = $${QTWEBKITLIBNAME}d

The QtLauncher linking break caused in debug mode caused the line above,
because if config doesn't contain debug_and_release, build_pass will
always false and QTWEBKITLIBNAME won't have necessarily "d" suffix.

Removing build_pass guard fix this bug and won't change anything.

I know modifying mkspec isn't the good solution, but it was an
experiment in first step. And I found it works. I'm going to
remove debug_and_release config from the WebKit build scripts
to decrease the runtime of building and avoid generating 
unnecessarily makefiles in an other bug.
Comment 3 Csaba Osztrogonác 2010-05-12 11:19:19 PDT
Comment on attachment 55872 [details]
Patch

cq- -ed, because I would like to land it manually.
Comment 4 Kenneth Rohde Christiansen 2010-05-12 13:42:19 PDT
Comment on attachment 55872 [details]
Patch

Be aware that this will conflict with Laszlo's patch on the cq.
Comment 5 Csaba Osztrogonác 2010-05-12 14:10:12 PDT
Landed, conflict resolved manually: http://trac.webkit.org/changeset/59266