Bug 39006 – [Qt] Link error in debug mode without debug_and_release config

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

I experimented with removing default debug_and_release config from win32-g++/qmake.conf . 
Now qmake runs twice unnecessarly and generate makefiles for release and debug mode too.

After removing debug build broke because of a little bug. Fix is coming soon.

[Csaba Osztrogonác]

Created attachment 55872 [details]
Patch

[Csaba Osztrogonác]

-                CONFIG(debug, debug|release):build_pass: QTWEBKITLIBNAME = $${QTWEBKITLIBNAME}d
+                CONFIG(debug, debug|release):QTWEBKITLIBNAME = $${QTWEBKITLIBNAME}d

The QtLauncher linking break caused in debug mode caused the line above,
because if config doesn't contain debug_and_release, build_pass will
always false and QTWEBKITLIBNAME won't have necessarily "d" suffix.

Removing build_pass guard fix this bug and won't change anything.

I know modifying mkspec isn't the good solution, but it was an
experiment in first step. And I found it works. I'm going to
remove debug_and_release config from the WebKit build scripts
to decrease the runtime of building and avoid generating 
unnecessarily makefiles in an other bug.

[Csaba Osztrogonác]

Comment on attachment 55872 [details]
Patch

cq- -ed, because I would like to land it manually.

[Kenneth Rohde Christiansen]

Comment on attachment 55872 [details]
Patch

Be aware that this will conflict with Laszlo's patch on the cq.

[Csaba Osztrogonác]

Landed, conflict resolved manually: http://trac.webkit.org/changeset/59266